Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3544)

Unified Diff: chrome/browser/ui/cocoa/tracking_area.h

Issue 6480067: [Mac] Placate Clang's (pedantic) warning about CrTrackingArea's initializer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tracking_area.h
diff --git a/chrome/browser/ui/cocoa/tracking_area.h b/chrome/browser/ui/cocoa/tracking_area.h
index 26cb2eff778b4412fc1aa9f434f45b948ee5df88..c12c2fd39b2bba9fe0c881c7378a342c9ccf28f7 100644
--- a/chrome/browser/ui/cocoa/tracking_area.h
+++ b/chrome/browser/ui/cocoa/tracking_area.h
@@ -20,9 +20,16 @@
// Designated initializer. Forwards all arguments to the superclass, but wraps
// |owner| in a proxy object.
+//
+// The |proxiedOwner:| paramater has been renamed due to an incompatiblity with
+// the 10.5 SDK. Since that SDK version declares |-[NSTrackingArea's init...]|'s
+// return type to be |NSTrackingArea*| rather than |id|, a more generalized type
+// can't be returned by the subclass. Until the project switches to the 10.6 SDK
+// (where Apple changed the return type to |id|), this ugly hack must exist.
+// TODO(rsesek): Remove this when feasabile.
Nico 2011/02/15 13:57:51 s/when feasible/when switch to 10.6 SDK is done/?
- (id)initWithRect:(NSRect)rect
options:(NSTrackingAreaOptions)options
- owner:(id)owner
+ proxiedOwner:(id)owner // 10.5 SDK hack. Remove at some point.
userInfo:(NSDictionary*)userInfo;
// Prevents any future messages from being delivered to the |owner|.

Powered by Google App Engine
This is Rietveld 408576698