Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 6480067: [Mac] Placate Clang's (pedantic) warning about CrTrackingArea's initializer. (Closed)

Created:
9 years, 10 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., Scott Hess - ex-Googler
Visibility:
Public.

Description

[Mac] Placate Clang's (pedantic) warning about CrTrackingArea's initializer. BUG=48709 TEST=Mac Clang compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74945

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tracking_area.h View 1 chunk +8 lines, -1 line 1 comment Download
M chrome/browser/ui/cocoa/tracking_area.mm View 2 chunks +10 lines, -1 line 1 comment Download
M chrome/browser/ui/cocoa/tracking_area_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
9 years, 10 months ago (2011-02-15 13:55:04 UTC) #1
Nico
LG almost worth filing a bug, but meh http://codereview.chromium.org/6480067/diff/1/chrome/browser/ui/cocoa/tracking_area.h File chrome/browser/ui/cocoa/tracking_area.h (right): http://codereview.chromium.org/6480067/diff/1/chrome/browser/ui/cocoa/tracking_area.h#newcode29 chrome/browser/ui/cocoa/tracking_area.h:29: // ...
9 years, 10 months ago (2011-02-15 13:57:51 UTC) #2
Scott Hess - ex-Googler
LGTM ... assuming the clang trybot failure isn't yours :-). -scott On Tue, Feb 15, ...
9 years, 10 months ago (2011-02-15 15:57:20 UTC) #3
Nico
9 years, 10 months ago (2011-02-15 18:44:59 UTC) #4
No, the trybot failed because it needs a clobber due to r74841

Powered by Google App Engine
This is Rietveld 408576698