 Chromium Code Reviews
 Chromium Code Reviews Issue 6480033:
  Implement experimental.contentSettings.misc.blockThirdPartyCookies.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 6480033:
  Implement experimental.contentSettings.misc.blockThirdPartyCookies.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/extensions/extension_prefs.cc | 
| diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc | 
| index 4bc61a8ab686586a58617af905d4a00dea0a5414..1dc4dc5ad85861b41cd674f41a942099d1b5c15f 100644 | 
| --- a/chrome/browser/extensions/extension_prefs.cc | 
| +++ b/chrome/browser/extensions/extension_prefs.cc | 
| @@ -1253,9 +1253,14 @@ void ExtensionPrefs::SetExtensionControlledPref(const std::string& extension_id, | 
| const std::string& pref_key, | 
| bool incognito, | 
| Value* value) { | 
| - DCHECK(pref_service()->FindPreference(pref_key.c_str())) | 
| - << "Extension controlled preference key " << pref_key | 
| - << " not registered."; | 
| +#ifndef NDEBUG | 
| + const PrefService::Preference* pref = | 
| + pref_service()->FindPreference(pref_key.c_str()); | 
| + DCHECK(pref) << "Extension controlled preference key " << pref_key | 
| + << " not registered."; | 
| + DCHECK_EQ(pref->GetType(), value->GetType()) | 
| + << "Extension controlled preference " << pref_key << " has wrong type"; | 
| 
battre
2011/02/11 13:49:02
Nit: . before last "?
 
Bernhard Bauer
2011/02/11 15:27:15
Done.
 | 
| +#endif | 
| if (!incognito) { | 
| // Also store in persisted Preferences file to recover after a |