Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 6480033: Implement experimental.contentSettings.misc.blockThirdPartyCookies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_prefs.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_prefs.cc
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc
index 4a4c40f0d9d821ef8b28aeb2b0d8ec1276f14377..a7ff547a58811de6dbe139cfa2d5f50a7d87451e 100644
--- a/chrome/browser/extensions/extension_prefs.cc
+++ b/chrome/browser/extensions/extension_prefs.cc
@@ -1277,9 +1277,14 @@ void ExtensionPrefs::SetExtensionControlledPref(const std::string& extension_id,
const std::string& pref_key,
bool incognito,
Value* value) {
- DCHECK(pref_service()->FindPreference(pref_key.c_str()))
- << "Extension controlled preference key " << pref_key
- << " not registered.";
+#ifndef NDEBUG
+ const PrefService::Preference* pref =
+ pref_service()->FindPreference(pref_key.c_str());
+ DCHECK(pref) << "Extension controlled preference key " << pref_key
+ << " not registered.";
+ DCHECK_EQ(pref->GetType(), value->GetType())
+ << "Extension controlled preference " << pref_key << " has wrong type.";
+#endif
if (!incognito) {
// Also store in persisted Preferences file to recover after a
« no previous file with comments | « chrome/browser/extensions/extension_prefs.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698