Implement experimental.contentSettings.misc.blockThirdPartyCookies.

chrome/browser/extensions/extension_prefs.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_prefs.h"
 
 #include "base/string_util.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_pref_store.h"
@@ skipping 1235 matching lines @@
   }
 
   extension_pref_value_map_->NotifyInitializationCompleted();
 }
 
 
 void ExtensionPrefs::SetExtensionControlledPref(const std::string& extension_id,
                                                 const std::string& pref_key,
                                                 bool incognito,
                                                 Value* value) {
-  DCHECK(pref_service()->FindPreference(pref_key.c_str()))
-      << "Extension controlled preference key " << pref_key
-      << " not registered.";
+#ifndef NDEBUG

[Aaron Boodman, 2011/02/11 18:33:19]

I think you should do this in all situations, not just debug.

[Bernhard Bauer, 2011/02/13 18:19:12]

So, also make them into |CHECK|s? Ideally, we'd already have checks before that
(like in extension_preference_api.cc), so this should only be necessary as an
additional precaution.

[Aaron Boodman, 2011/02/14 02:54:02]

I see. Ok, I don't feel so strongly about this case.

+  const PrefService::Preference* pref =
+      pref_service()->FindPreference(pref_key.c_str());
+  DCHECK(pref) << "Extension controlled preference key " << pref_key
+               << " not registered.";
+  DCHECK_EQ(pref->GetType(), value->GetType())
+      << "Extension controlled preference " << pref_key << " has wrong type.";
+#endif
 
   if (!incognito) {
     // Also store in persisted Preferences file to recover after a
     // browser restart.
     DictionaryValue* dict = GetExtensionControlledPrefs(extension_id);
     dict->SetWithoutPathExpansion(pref_key, value->DeepCopy());
     pref_service()->ScheduleSavePersistentPrefs();
   }
 
   extension_pref_value_map_->SetExtensionPref(
@@ skipping 24 matching lines @@
 void ExtensionPrefs::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterDictionaryPref(kExtensionsPref);
   prefs->RegisterListPref(kExtensionToolbar);
   prefs->RegisterIntegerPref(prefs::kExtensionToolbarSize, -1);
   prefs->RegisterDictionaryPref(kExtensionsBlacklistUpdate);
   prefs->RegisterListPref(prefs::kExtensionInstallAllowList);
   prefs->RegisterListPref(prefs::kExtensionInstallDenyList);
   prefs->RegisterListPref(prefs::kExtensionInstallForceList);
   prefs->RegisterStringPref(kWebStoreLogin, std::string() /* default_value */);
 }