Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 6480030: Remove the uses of the arguments from all calls. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Remove the uses of the arguments from all calls. Before, Hydrogen call instructions had uses of the PushArgument instructions for their arguments. These operands were unneeded, bloated the IR, and caused calls to be the only Hydrogen instructions with an unpredictable number of operands. Now, PushArgument is a pure side-effecting instruction that has no uses. Committed: http://code.google.com/p/v8/source/detail?r=6749

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -319 lines) Patch
M src/hydrogen.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 19 chunks +34 lines, -44 lines 0 comments Download
M src/hydrogen-instructions.h View 9 chunks +91 lines, -143 lines 1 comment Download
M src/hydrogen-instructions.cc View 5 chunks +52 lines, -127 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
These operands were unused and only complicated things. I've left the position of the PushArguments ...
9 years, 10 months ago (2011-02-10 13:10:19 UTC) #1
fschneider
9 years, 10 months ago (2011-02-11 13:08:17 UTC) #2
LGTM!

http://codereview.chromium.org/6480030/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/6480030/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:1169: HValue* value_;
You could consider using OperandVector<1> instead. It should be as fast in
release mode and has asserts in debug mode.

Powered by Google App Engine
This is Rietveld 408576698