crash-reporter: when exe symlink read fails send diags and still ignore chrome crashes

crash_reporter.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_util.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/string_util.h"
@@ skipping 130 matching lines @@
   // Handle a specific user space crash.
   CHECK(!FLAGS_user.empty()) << "--user= must be set";
 
   // Make it possible to test what happens when we crash while
   // handling a crash.
   if (FLAGS_crash_test) {
     *(char *)0 = 0;
     return 0;
   }
 
+  // Accumulate logs to help in diagnosing failures during user collection.
+  s_system_log.set_accumulating(true);
   // Handle the crash, get the name of the process from procfs.
-  if (!user_collector->HandleCrash(FLAGS_user, NULL)) {
+  bool handled = user_collector->HandleCrash(FLAGS_user, NULL);
+  s_system_log.set_accumulating(false);
+  if (!handled)
     return 1;
-  }
   return 0;
 }
 
 // Interactive/diagnostics mode for generating kernel crash signatures.
 static int GenerateKernelSignature(KernelCollector *kernel_collector) {
   std::string kcrash_contents;
   std::string signature;
   if (!file_util::ReadFileToString(FilePath(FLAGS_generate_kernel_signature),
                                    &kcrash_contents)) {
     fprintf(stderr, "Could not read file.\n");
@@ skipping 47 matching lines @@
     user_collector.Disable();
     return 0;
   }
 
   if (!FLAGS_generate_kernel_signature.empty()) {
     return GenerateKernelSignature(&kernel_collector);
   }
 
   return HandleUserCrash(&user_collector);
 }