src/factory.cc - Issue 6480003: Fix various places which do not check if SetProperty threw an exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 6480003: Fix various places which do not check if SetProperty threw an exception. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Minor improvement Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index a3d55921b67e679ad0f14aa39aac4836198a5306..adf03862052f02f0853816218504f633ae4b2df4 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -580,7 +580,9 @@ Handle<JSFunction> Factory::NewFunctionWithPrototype(Handle<String> name,

// Set function.prototype and give the prototype a constructor

// property that refers to the function.

SetPrototypeProperty(function, prototype);

- SetProperty(prototype, Factory::constructor_symbol(), function, DONT_ENUM);

+ // Currently save as is only invoked from Genesis.

Mads Ager (chromium) 2011/02/10 10:26:43 save as -> safe because it

antonm 2011/02/10 14:18:33 Done.

+ SetLocalPropertyNoThrow(

+ prototype, Factory::constructor_symbol(), function, DONT_ENUM);

return function;

}

« no previous file with comments | « src/debug.cc ('k') | src/handles.h » ('j') | no next file with comments »