Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6480001: Migrate Event API methods to Google Style. (Closed)

Created:
9 years, 10 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Migrate Event API methods to Google Style. BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -229 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_views.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/captcha_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_view.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/guest_user_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views_unittest.cc View 1 2 2 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download_item_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/options/cookies_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/button/button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/button_dropdown.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/custom_button.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M views/controls/button/menu_button.cc View 1 1 chunk +12 lines, -8 lines 0 comments Download
M views/controls/combobox/combobox.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/link.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M views/controls/menu/submenu_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/scrollbar/bitmap_scroll_bar.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/textfield/native_textfield_views.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M views/controls/textfield/textfield.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/events/event.h View 1 9 chunks +39 lines, -87 lines 0 comments Download
M views/focus/focus_manager.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A views/native_types.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
M views/view_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/widget/root_view.cc View 1 9 chunks +13 lines, -13 lines 0 comments Download
M views/widget/widget_gtk.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
9 years, 10 months ago (2011-02-09 22:39:59 UTC) #1
Ben Goodger (Google)
Strategy: native_types.h event.h event.cc The rest is just updating.
9 years, 10 months ago (2011-02-09 22:40:20 UTC) #2
sky
9 years, 10 months ago (2011-02-09 22:54:08 UTC) #3 
LGTM with the following change

http://codereview.chromium.org/6480001/diff/4008/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/textfield_with_margin.cc (right):

http://codereview.chromium.org/6480001/diff/4008/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/textfield_with_margin.cc:39: if (e.() ==
ui::VKEY_ESCAPE && !text().empty()) {
key_code

Powered by Google App Engine
This is Rietveld 408576698