Issue 6479019: Port bug fixes to optimized Function.prototype.apply to ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6479019: Port bug fixes to optimized Function.prototype.apply to ARM. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Port bug fixes to optimized Function.prototype.apply to ARM. There were a couple of bug fixes to this code on IA32 which have not yet been ported to ARM. They are: failure to correctly handle non-JSObject receivers and failure to restore the context register after calling JS code. Committed: http://code.google.com/p/v8/source/detail?r=6744

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -29 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		3 chunks	+20 lines, -15 lines	0 comments	Download
	M	src/ia32/lithium-codegen-ia32.cc	View		4 chunks	+13 lines, -14 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/6479019/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6479019/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2206 src/ia32/lithium-codegen-ia32.cc:2206: Label invoke, loop; NearLabels?

9 years, 10 months ago (2011-02-11 10:04:03 UTC) #2

Kevin Millikin (Chromium)

9 years, 10 months ago (2011-02-11 11:22:16 UTC) #3

http://codereview.chromium.org/6479019/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6479019/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:2206: Label invoke, loop;
On 2011/02/11 10:04:03, fschneider wrote:
> NearLabels?

Yes, good catch.

Expand Messages | Collapse Messages