Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 6479014: Fix bug in register requirements for function.apply.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: added ARM files Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 // temporaries and outputs because all registers 75 // temporaries and outputs because all registers
76 // are blocked by the calling convention. 76 // are blocked by the calling convention.
77 // Inputs can use either fixed register or have a short lifetime (be 77 // Inputs can use either fixed register or have a short lifetime (be
78 // used at start of the instruction). 78 // used at start of the instruction).
79 ASSERT(Output() == NULL || 79 ASSERT(Output() == NULL ||
80 LUnallocated::cast(Output())->HasFixedPolicy() || 80 LUnallocated::cast(Output())->HasFixedPolicy() ||
81 !LUnallocated::cast(Output())->HasRegisterPolicy()); 81 !LUnallocated::cast(Output())->HasRegisterPolicy());
82 for (UseIterator it(this); it.HasNext(); it.Advance()) { 82 for (UseIterator it(this); it.HasNext(); it.Advance()) {
83 LOperand* operand = it.Next(); 83 LOperand* operand = it.Next();
84 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() || 84 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() ||
85 LUnallocated::cast(operand)->IsUsedAtStart() ||
86 !LUnallocated::cast(operand)->HasRegisterPolicy()); 85 !LUnallocated::cast(operand)->HasRegisterPolicy());
87 } 86 }
88 for (TempIterator it(this); it.HasNext(); it.Advance()) { 87 for (TempIterator it(this); it.HasNext(); it.Advance()) {
89 LOperand* operand = it.Next(); 88 LOperand* operand = it.Next();
90 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() || 89 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() ||
91 !LUnallocated::cast(operand)->HasRegisterPolicy()); 90 !LUnallocated::cast(operand)->HasRegisterPolicy());
92 } 91 }
93 } 92 }
94 #endif 93 #endif
95 94
(...skipping 1052 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 UseFixed(instr->value(), InstanceofStub::left()), 1147 UseFixed(instr->value(), InstanceofStub::left()),
1149 FixedTemp(edi)); 1148 FixedTemp(edi));
1150 MarkAsSaveDoubles(result); 1149 MarkAsSaveDoubles(result);
1151 return AssignEnvironment(AssignPointerMap(DefineFixed(result, eax))); 1150 return AssignEnvironment(AssignPointerMap(DefineFixed(result, eax)));
1152 } 1151 }
1153 1152
1154 1153
1155 LInstruction* LChunkBuilder::DoApplyArguments(HApplyArguments* instr) { 1154 LInstruction* LChunkBuilder::DoApplyArguments(HApplyArguments* instr) {
1156 LOperand* function = UseFixed(instr->function(), edi); 1155 LOperand* function = UseFixed(instr->function(), edi);
1157 LOperand* receiver = UseFixed(instr->receiver(), eax); 1156 LOperand* receiver = UseFixed(instr->receiver(), eax);
1158 LOperand* length = UseRegisterAtStart(instr->length()); 1157 LOperand* length = UseFixed(instr->length(), ebx);
1159 LOperand* elements = UseRegisterAtStart(instr->elements()); 1158 LOperand* elements = UseFixed(instr->elements(), ecx);
1160 LOperand* temp = FixedTemp(ebx); 1159 LOperand* temp = FixedTemp(edx);
1161 LApplyArguments* result = new LApplyArguments(function, 1160 LApplyArguments* result = new LApplyArguments(function,
1162 receiver, 1161 receiver,
1163 length, 1162 length,
1164 elements, 1163 elements,
1165 temp); 1164 temp);
1166 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY); 1165 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY);
1167 } 1166 }
1168 1167
1169 1168
1170 LInstruction* LChunkBuilder::DoPushArgument(HPushArgument* instr) { 1169 LInstruction* LChunkBuilder::DoPushArgument(HPushArgument* instr) {
(...skipping 820 matching lines...) Expand 10 before | Expand all | Expand 10 after
1991 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 1990 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
1992 HEnvironment* outer = current_block_->last_environment()->outer(); 1991 HEnvironment* outer = current_block_->last_environment()->outer();
1993 current_block_->UpdateEnvironment(outer); 1992 current_block_->UpdateEnvironment(outer);
1994 return NULL; 1993 return NULL;
1995 } 1994 }
1996 1995
1997 1996
1998 } } // namespace v8::internal 1997 } } // namespace v8::internal
1999 1998
2000 #endif // V8_TARGET_ARCH_IA32 1999 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698