presubmit_support.py - Issue 6479006: scm.SVN.GenerateDiff() expects an array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 6479006: scm.SVN.GenerateDiff() expects an array. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index 6be415dce140a70e9e26cb334b91d9a6d4160a49..38d29902752bc176f7175cd3fbc27cd190f3156f 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -558,7 +558,8 @@ class SvnAffectedFile(AffectedFile):

return self._is_text_file

def GenerateScmDiff(self):

- return scm.SVN.GenerateDiff(self.AbsoluteLocalPath())

+ return scm.SVN.GenerateDiff([self.AbsoluteLocalPath()])

class GitAffectedFile(AffectedFile):

"""Representation of a file in a change out of a git checkout."""

« no previous file with comments | « no previous file | no next file » | no next file with comments »