scm.SVN.GenerateDiff() expects an array.

scm.SVN.GenerateDiff() expects an array.

So pass a single item array. The presubmit checks would fail otherwise.

This code path was definitely not exercised by the unit tests. Unit tests are
left as an exercise to the reader.

TBR=vbendeb
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74396

[vb, 2011-02-10 01:30:12]

LGTM

too bad when testing in real directory it was a git case...


On Wed, Feb 9, 2011 at 5:22 PM, <maruel@chromium.org> wrote:

> Reviewers: vb,
>
> Description:
> scm.SVN.GenerateDiff() expects an array.
>
> So pass a single item array. The presubmit checks would fail otherwise.
>
> This code path was definitely not exercised by the unit tests. Unit tests
> are
> left as an exercise to the reader.
>
> TBR=vbendeb
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6479006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files:
>  M presubmit_support.py
>
>
> Index: presubmit_support.py
> diff --git a/presubmit_support.py b/presubmit_support.py
> index
>
6be415dce140a70e9e26cb334b91d9a6d4160a49..38d29902752bc176f7175cd3fbc27cd190f3156f
> 100755
> --- a/presubmit_support.py
> +++ b/presubmit_support.py
> @@ -558,7 +558,8 @@ class SvnAffectedFile(AffectedFile):
>     return self._is_text_file
>
>   def GenerateScmDiff(self):
> -    return scm.SVN.GenerateDiff(self.AbsoluteLocalPath())
> +    return scm.SVN.GenerateDiff([self.AbsoluteLocalPath()])
> +
>
>  class GitAffectedFile(AffectedFile):
>   """Representation of a file in a change out of a git checkout."""
>
>
>

[commit-bot: I haz the power, 2011-02-10 01:34:01]

Change committed as 74396