Issue 6479004: Print Preview: Hook up the print button to initiate a normal print operation....

Issue 6479004: Print Preview: Hook up the print button to initiate a normal print operation.... (Closed)

Created:
9 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
sanjeevr, jam, kmadhusu

CC:
chromium-reviews, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Print Preview: Hook up the print button to initiate a normal print operation. BUG=none TEST=Enable print preview on Mac, make sure print button in print preview works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75302

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : rebase #

Patch Set 4 : add a comment #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
M	chrome/browser/dom_ui/print_preview_handler.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/print_preview_handler.cc	View	1 2 3	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/print_preview.js	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	1 2 3	3 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Thanks to John's work for printing embedded PDFs from a context menu, I can do ...

9 years, 10 months ago (2011-02-10 00:58:47 UTC) #1

jam

lgtm http://codereview.chromium.org/6479004/diff/6001/chrome/common/render_messages_internal.h File chrome/common/render_messages_internal.h (right): http://codereview.chromium.org/6479004/diff/6001/chrome/common/render_messages_internal.h#newcode132 chrome/common/render_messages_internal.h:132: IPC_MESSAGE_ROUTED0(ViewMsg_PrintForPrintPreview) nit: comment?

9 years, 10 months ago (2011-02-10 01:29:13 UTC) #2

Lei Zhang

On 2011/02/10 01:29:13, John Abd-El-Malek wrote: > lgtm > > http://codereview.chromium.org/6479004/diff/6001/chrome/common/render_messages_internal.h > File chrome/common/render_messages_internal.h (right): ...

9 years, 10 months ago (2011-02-10 02:14:35 UTC) #3

kmadhusu

9 years, 10 months ago (2011-02-10 02:16:24 UTC) #4

LGTM

On 2011/02/10 02:14:35, Lei Zhang wrote:
> On 2011/02/10 01:29:13, John Abd-El-Malek wrote:
> > lgtm
> > 
> >
>
http://codereview.chromium.org/6479004/diff/6001/chrome/common/render_message...
> > File chrome/common/render_messages_internal.h (right):
> > 
> >
>
http://codereview.chromium.org/6479004/diff/6001/chrome/common/render_message...
> > chrome/common/render_messages_internal.h:132:
> > IPC_MESSAGE_ROUTED0(ViewMsg_PrintForPrintPreview)
> > nit: comment?
> 
> Added comment, and simplified the code in print_preview_handler.cc a little
bit.

Expand Messages | Collapse Messages