Temporarily disable restrictions on who can request chrome-extension://

Temporarily disable restrictions on who can request chrome-extension://.

These checks were causing lots of subtle bugs and fixing them will be difficult to get correct for the upcoming milestone. The checks were originally intended to be an 'extra line of defense' and are not critical for security.

I will reintroduce them separately on trunk.

BUG=72455, 72407
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74511

[Aaron Boodman, 2011-02-10 05:25:50]

http://codereview.chromium.org/6478019/diff/1/chrome/common/render_messages_p...
File chrome/common/render_messages_params.cc (left):

http://codereview.chromium.org/6478019/diff/1/chrome/common/render_messages_p...
chrome/common/render_messages_params.cc:303: extension_manifest_keys::kApp
We were not copying the content_scripts key, which was needed to get the right
answer in ExtensionResourceRequestPolicy sometimes.

In retrospect, this was a bug waiting to happen and probably a case of early
optimization, so simplified.

http://codereview.chromium.org/6478019/diff/1/chrome/renderer/render_view.cc
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/6478019/diff/1/chrome/renderer/render_view.cc#...
chrome/renderer/render_view.cc:3630: GURL(frame->securityOrigin().toString()),
In the case of iframes that are dynamically created and never assigned a src,
frame->url() will be "about:blank", but the security origin is inherited from
the parent document.

[Aaron Boodman, 2011-02-10 08:07:52]

Ugh, this does not work. Hold off reviewing for now please.

[Aaron Boodman, 2011-02-10 19:44:09]

Ok, this is a different approach that just disables the most complex of the
checks that are causing all the problems.

I will add the checks back but they will take awhile to get correct, and we have
no time for the upcoming branch.

[Matt Perry, 2011-02-10 19:50:57]

http://codereview.chromium.org/6478019/diff/12/chrome/renderer/extensions/ext...
File chrome/renderer/extensions/extension_resource_request_policy.cc (left):

http://codereview.chromium.org/6478019/diff/12/chrome/renderer/extensions/ext...
chrome/renderer/extensions/extension_resource_request_policy.cc:40: //
Otherwise, pages are allowed to load resources from extensions if the
Shouldn't this check be added back to extension_resources.cc?

[Matt Perry, 2011-02-10 19:55:39]

lgtm