Issue 6476031: Initialize DropdownBarHost member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6476031: Initialize DropdownBarHost member (Closed)

Created:
9 years, 10 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Initialize DropdownBarHost member BUG=None TEST=None CID=14377 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75090

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/dropdown_bar_host.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

9 years, 10 months ago (2011-02-15 16:38:55 UTC) #2

LGTM

On Tue, Feb 15, 2011 at 2:30 AM, <finnur@chromium.org> wrote:

> Reviewers: oshima,
>
> Description:
> Initialize DropdownBarHost member
>
> BUG=None
> TEST=None
> CID=14377
>
>
> Please review this at http://codereview.chromium.org/6476031/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/ui/views/dropdown_bar_host.cc
>
>
> Index: chrome/browser/ui/views/dropdown_bar_host.cc
> ===================================================================
> --- chrome/browser/ui/views/dropdown_bar_host.cc        (revision 74265)
> +++ chrome/browser/ui/views/dropdown_bar_host.cc        (working copy)
> @@ -43,7 +43,9 @@
>
>  DropdownBarHost::DropdownBarHost(BrowserView* browser_view)
>     : browser_view_(browser_view),
> +      view_(NULL),
>       animation_offset_(0),
> +      focus_manager_(NULL),
>       esc_accel_target_registered_(false),
>       is_visible_(false) {
>  }
>
>
>

Expand Messages | Collapse Messages