Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 6476021: Mac: Fix warnings in nib files (Closed)

Created:
9 years, 10 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Ilya Sherman, James Hawkins, dhollowa, TVL
Visibility:
Public.

Description

Mac: Fix warnings in nib files With all this file moving, many nib files had outdated paths in them. I did: 1. A build of the "chrome" target 2. |open chrome/app/nibs/*.xib| 3. Wait for the communication between XCode and IB to cease 4. Hit Cmd-S Cmd-W for every nib window This was with xcode 3.2.5 on OS X 10.6 57 files changed, 21802 insertions(+), 1258 deletions(-) No intended behavior change. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74440

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21802 lines, -1258 lines) Patch
M chrome/app/nibs/About.xib View 8 chunks +175 lines, -6 lines 0 comments Download
M chrome/app/nibs/AboutIPC.xib View 31 chunks +924 lines, -62 lines 0 comments Download
M chrome/app/nibs/AutoFillAddressSheet.xib View 5 chunks +69 lines, -5 lines 0 comments Download
M chrome/app/nibs/AutoFillCreditCardSheet.xib View 4 chunks +6 lines, -13 lines 0 comments Download
M chrome/app/nibs/AutoFillDialog.xib View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/app/nibs/BookmarkAllTabs.xib View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/nibs/BookmarkBar.xib View 18 chunks +294 lines, -11 lines 0 comments Download
M chrome/app/nibs/BookmarkBarFolderWindow.xib View 4 chunks +6 lines, -13 lines 0 comments Download
M chrome/app/nibs/BookmarkBubble.xib View 8 chunks +155 lines, -6 lines 0 comments Download
M chrome/app/nibs/BookmarkEditor.xib View 34 chunks +971 lines, -54 lines 0 comments Download
M chrome/app/nibs/BookmarkNameFolder.xib View 22 chunks +869 lines, -36 lines 0 comments Download
M chrome/app/nibs/BrowserWindow.xib View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/app/nibs/ClearBrowsingData.xib View 27 chunks +934 lines, -46 lines 0 comments Download
M chrome/app/nibs/CollectedCookies.xib View 10 chunks +175 lines, -8 lines 0 comments Download
M chrome/app/nibs/ConfirmQuitPanel.xib View 3 chunks +748 lines, -20 lines 0 comments Download
M chrome/app/nibs/ContentBlockedCookies.xib View 25 chunks +917 lines, -38 lines 0 comments Download
M chrome/app/nibs/ContentBlockedImages.xib View 31 chunks +964 lines, -50 lines 0 comments Download
M chrome/app/nibs/ContentBlockedJavaScript.xib View 31 chunks +964 lines, -50 lines 0 comments Download
M chrome/app/nibs/ContentBlockedPlugins.xib View 10 chunks +175 lines, -6 lines 0 comments Download
M chrome/app/nibs/ContentBlockedPopups.xib View 31 chunks +964 lines, -50 lines 0 comments Download
M chrome/app/nibs/ContentBubbleGeolocation.xib View 24 chunks +948 lines, -42 lines 0 comments Download
M chrome/app/nibs/ContentExceptionsWindow.xib View 32 chunks +968 lines, -58 lines 0 comments Download
M chrome/app/nibs/ContentSettings.xib View 5 chunks +7 lines, -14 lines 0 comments Download
M chrome/app/nibs/CookieDetailsView.xib View 8 chunks +122 lines, -5 lines 0 comments Download
M chrome/app/nibs/Cookies.xib View 9 chunks +177 lines, -7 lines 0 comments Download
M chrome/app/nibs/DownloadItem.xib View 13 chunks +218 lines, -8 lines 0 comments Download
M chrome/app/nibs/DownloadShelf.xib View 10 chunks +192 lines, -5 lines 0 comments Download
M chrome/app/nibs/EditSearchEngine.xib View 24 chunks +412 lines, -22 lines 0 comments Download
M chrome/app/nibs/ExtensionInstallPrompt.xib View 5 chunks +9 lines, -19 lines 0 comments Download
M chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib View 8 chunks +138 lines, -6 lines 0 comments Download
M chrome/app/nibs/ExtensionInstalledBubble.xib View 5 chunks +7 lines, -14 lines 0 comments Download
M chrome/app/nibs/FindBar.xib View 10 chunks +105 lines, -9 lines 0 comments Download
M chrome/app/nibs/FirstRunBubble.xib View 22 chunks +782 lines, -34 lines 0 comments Download
M chrome/app/nibs/FirstRunDialog.xib View 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/app/nibs/FontLanguageSettings.xib View 28 chunks +989 lines, -44 lines 0 comments Download
M chrome/app/nibs/HttpAuthLoginSheet.xib View 10 chunks +183 lines, -8 lines 0 comments Download
M chrome/app/nibs/HungRendererDialog.xib View 31 chunks +936 lines, -50 lines 0 comments Download
M chrome/app/nibs/ImportProgressDialog.xib View 21 chunks +838 lines, -36 lines 0 comments Download
M chrome/app/nibs/ImportSettingsDialog.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/InfoBar.xib View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/app/nibs/InfoBarContainer.xib View 8 chunks +669 lines, -23 lines 0 comments Download
M chrome/app/nibs/InstantConfirm.xib View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/app/nibs/InstantOptIn.xib View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/nibs/KeywordEditor.xib View 5 chunks +863 lines, -23 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 7 chunks +12 lines, -22 lines 0 comments Download
M chrome/app/nibs/Notification.xib View 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/app/nibs/Preferences.xib View 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/app/nibs/PreviewableContents.xib View 6 chunks +14 lines, -67 lines 0 comments Download
M chrome/app/nibs/ReportBug.xib View 26 chunks +926 lines, -45 lines 0 comments Download
M chrome/app/nibs/SadTab.xib View 20 chunks +835 lines, -42 lines 1 comment Download
M chrome/app/nibs/SaveAccessoryView.xib View 17 chunks +809 lines, -32 lines 0 comments Download
M chrome/app/nibs/SearchEngineDialog.xib View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/nibs/SimpleContentExceptionsWindow.xib View 10 chunks +134 lines, -7 lines 0 comments Download
M chrome/app/nibs/SpeechInputBubble.xib View 8 chunks +114 lines, -4 lines 0 comments Download
M chrome/app/nibs/TabView.xib View 8 chunks +105 lines, -7 lines 0 comments Download
M chrome/app/nibs/TaskManager.xib View 31 chunks +927 lines, -50 lines 0 comments Download
M chrome/app/nibs/Toolbar.xib View 9 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
http://i.imgur.com/PJBjn.png http://i.imgur.com/NUHZG.png
9 years, 10 months ago (2011-02-10 03:25:29 UTC) #1
Robert Sesek
9 years, 10 months ago (2011-02-10 16:22:49 UTC) #2
LGTM. Thanks for doing this!

http://codereview.chromium.org/6476021/diff/1/chrome/app/nibs/SadTab.xib
File chrome/app/nibs/SadTab.xib (right):

http://codereview.chromium.org/6476021/diff/1/chrome/app/nibs/SadTab.xib#newc...
chrome/app/nibs/SadTab.xib:525: <string
key="minorKey">browser/ui/cocoa/objc_zombie.h</string>
I wonder why it picked this up.

Powered by Google App Engine
This is Rietveld 408576698