Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 6475018: Remove declaration for function removed more than half a year ago in r56752. (Closed)

Created:
9 years, 10 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Remove declaration for function removed more than half a year ago in r56752. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
9 years, 10 months ago (2011-02-14 21:32:08 UTC) #1
brettw
9 years, 10 months ago (2011-02-14 22:02:09 UTC) #2
LGTM

On Mon, Feb 14, 2011 at 1:32 PM,  <avi@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Remove declaration for function removed more than half a year ago in r56752.
>
>
> Please review this at http://codereview.chromium.org/6475018/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/ui/browser.h
>
>
> Index: chrome/browser/ui/browser.h
> ===================================================================
> --- chrome/browser/ui/browser.h (revision 74836)
> +++ chrome/browser/ui/browser.h (working copy)
> @@ -938,24 +938,6 @@
>
>   // Assorted utility functions
> ///////////////////////////////////////////////
>
> -  // Checks whether |source| is about to navigate across extension extents,
> and
> -  // if so, navigates in the correct window. For example if this is a
> normal
> -  // browser and we're about to navigate into an extent, this method will
> -  // navigate the app's window instead. If we're in an app window and
> -  // navigating out of the app, this method will find and navigate a normal
> -  // browser instead.
> -  //
> -  // Returns true if the navigation was handled, eg, it was opened in some
> other
> -  // browser.
> -  //
> -  // Returns false if it was not handled. In this case, the method may also
> -  // modify |disposition| to a more suitable value.
> -  bool HandleCrossAppNavigation(TabContents* source,
> -                                const GURL& url,
> -                                const GURL& referrer,
> -                                WindowOpenDisposition *disposition,
> -                                PageTransition::Type transition);
> -
>   // Shows the Find Bar, optionally selecting the next entry that matches
> the
>   // existing search string for that Tab. |forward_direction| controls the
>   // search direction.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698