Issue 6475012: X64 Crankshaft: Fix bug in pushed registers at safepoints. Fixes issue 1153 ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6475012: X64 Crankshaft: Fix bug in pushed registers at safepoints. Fixes issue 1153 ... (Closed)

Created:
9 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Fix bug in pushed registers at safepoints. Fixes issue 1153 completely. BUG=1153 TEST=mjsunit/mul-exhaustive TBR=kmillikin@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=6779

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	src/x64/macro-assembler-x64.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/x64/macro-assembler-x64.cc	View		2 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/6475012/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/6475012/diff/1/src/x64/macro-assembler-x64.cc#newcode1447 src/x64/macro-assembler-x64.cc:1447: (kNumSafepointRegisters-kNumSafepointSavedRegisters) * kPointerSize)); I guess this needs to ...

9 years, 10 months ago (2011-02-14 18:42:21 UTC) #2

LGTM.

Expand Messages | Collapse Messages