Implemented policy to disable plugin finder.

chrome/default_plugin/plugin_impl_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/default_plugin/plugin_impl_win.h"
 
 #include <shellapi.h>
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/default_plugin/plugin_main.h"
 #include "googleurl/src/gurl.h"
 #include "grit/webkit_strings.h"
 #include "unicode/locid.h"
 #include "webkit/glue/webkit_glue.h"
 #include "webkit/plugins/npapi/default_plugin_shared.h"
 
 static const int TOOLTIP_MAX_WIDTH = 500;
 
 PluginInstallerImpl::PluginInstallerImpl(int16 mode)
     : instance_(NULL),
       mode_(mode),
+      disable_plugin_finder_(false),
       plugin_install_stream_(NULL),
       plugin_installer_state_(PluginInstallerStateUndefined),
       install_dialog_(NULL),
       enable_click_(false),
       icon_(NULL),
       bold_font_(NULL),
       regular_font_(NULL),
       underline_font_(NULL),
       tooltip_(NULL),
       installation_job_monitor_thread_(
           new PluginInstallationJobMonitorThread()),
       plugin_database_handler_(*this),
       plugin_download_url_for_display_(false) {
 }
 
 PluginInstallerImpl::~PluginInstallerImpl() {
-  installation_job_monitor_thread_->Stop();
+  if (!disable_plugin_finder_)
+    installation_job_monitor_thread_->Stop();
 
   if (bold_font_)
     DeleteObject(bold_font_);
 
   if (underline_font_)
     DeleteObject(underline_font_);
 
   if (tooltip_)
     DestroyWindow(tooltip_);
 }
@@ skipping 13 matching lines @@
 
   instance_ = instance;
   mime_type_ = mime_type;
 
   if (!webkit_glue::GetPluginFinderURL(&plugin_finder_url_)) {
     NOTREACHED();
     DLOG(WARNING) << __FUNCTION__ << " Failed to get the plugin finder URL";
     return false;
   }
 
-  if (!installation_job_monitor_thread_->Initialize()) {
-    DLOG(ERROR) << "Failed to initialize plugin install job";
-    NOTREACHED();
-    return false;
-  }
+  if (plugin_finder_url_.empty())
+    disable_plugin_finder_ = true;
 
   InitializeResources(module_handle);
 
-  DisplayStatus(IDS_DEFAULT_PLUGIN_GET_PLUGIN_MSG_NO_PLUGIN_NAME);
-  plugin_database_handler_.DownloadPluginsFileIfNeeded(plugin_finder_url_);
+  if (!disable_plugin_finder_) {
+    if (!installation_job_monitor_thread_->Initialize()) {
+      DLOG(ERROR) << "Failed to initialize plugin install job";

[Bernhard Bauer, 2011/02/24 10:37:07]

You can just |DLOG(FATAL)| here, or even simpler just |NOTREACHED() << "..."|.

[pastarmovj, 2011/02/24 16:02:20]

Actually I only moved this piece of code but i will anyhow tune it as well as
all same calls in  this function too.

[Bernhard Bauer, 2011/02/24 16:25:18]

Please do. Even if you're not the original author of the code, it's encouraged
to do minor cleanups as you come across them.

[pastarmovj, 2011/02/25 09:56:37]

Yep sure. :)

+      NOTREACHED();
+      return false;
+    }
+
+    DisplayStatus(IDS_DEFAULT_PLUGIN_GET_PLUGIN_MSG_NO_PLUGIN_NAME);
+    plugin_database_handler_.DownloadPluginsFileIfNeeded(plugin_finder_url_);
+  } else {
+    DisplayStatus(IDS_DEFAULT_PLUGIN_GET_PLUGIN_MSG_PLUGIN_FINDER_DISABLED);
+  }
 
   return true;
 }
 
 void PluginInstallerImpl::Shutdown() {
   if (install_dialog_) {
     install_dialog_->RemoveInstaller(this);
     install_dialog_ = NULL;
   }
 
@@ skipping 546 matching lines @@
   return true;
 }
 
 void PluginInstallerImpl::NotifyPluginStatus(int status) {
   default_plugin::g_browser->getvalue(
       instance_,
       static_cast<NPNVariable>(
           webkit::npapi::default_plugin::kMissingPluginStatusStart + status),
       NULL);
 }