Issue 6475009: Fix a duplicate AST ID recorded for for/in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6475009: Fix a duplicate AST ID recorded for for/in. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix a duplicate AST ID recorded for for/in. Avoid visiting the subexpressions of a variable that rewrites to a property when occurring as the 'left-hand side' of for/in. BUG=v8:1149 Committed: http://code.google.com/p/v8/source/detail?r=6772

Patch Set 1 #

Patch Set 2 : Uploaded x64 and ARM versions. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -13 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	1 chunk	+14 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+14 lines, -4 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	1 chunk	+15 lines, -5 lines	0 comments	Download
A	test/mjsunit/regress/regress-1149.js	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages