Issue 6474039: More x64 work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6474039: More x64 work. (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

More x64 work. x64: Implement DoArgumentsElements, DoNumberUntagD, DoArgumentsLength, DoAccessArgumentsAt, DoStringLength in lithium x64 backend. Fix a bug in DoConstantD where only 32-bits of a double was loaded to an xmm register. Committed: http://code.google.com/p/v8/source/detail?r=6771

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -24 lines)			Patch
M	src/x64/lithium-codegen-x64.cc	View	1	6 chunks	+76 lines, -15 lines	0 comments	Download
M	src/x64/lithium-x64.h	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		4 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Redirecting since Lasse is on vacation today.

9 years, 10 months ago (2011-02-14 09:37:23 UTC) #2

William Hesse

LGTM, with comment. http://codereview.chromium.org/6474039/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6474039/diff/1/src/x64/lithium-codegen-x64.cc#newcode899 src/x64/lithium-codegen-x64.cc:899: __ movl(tmp, Immediate(v_int32)); This integer-to-double conversion ...

9 years, 10 months ago (2011-02-14 11:39:25 UTC) #3

Mads Ager (chromium)

9 years, 10 months ago (2011-02-14 12:07:14 UTC) #4

http://codereview.chromium.org/6474039/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6474039/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:899: __ movl(tmp, Immediate(v_int32));
On 2011/02/14 11:39:25, William Hesse wrote:
> This integer-to-double conversion is slower than just loading the double from
a
> GP register, as done below, so remove this case, and use code below.

Done.

Expand Messages | Collapse Messages