Issue 6474038: Rename the variable to not end in "_file" since that triggers gyp relative...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6474038: Rename the variable to not end in "_file" since that triggers gyp relative... (Closed)

Created:
9 years, 10 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

Rename the variable to not end in "_file" since that triggers gyp relative path munging when you try to set it in common.gypi. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74592

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	icu.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Ah, right. LGTM.