Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6474037: Remove OProfile support. We have Linux Perf support, (Closed)

Created:
9 years, 10 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove OProfile support. We have Linux Perf support, and it is better because it supports code moves, so one can run the VM with default flags. Committed: http://code.google.com/p/v8/source/detail?r=6746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -333 lines) Patch
M SConstruct View 4 chunks +1 line, -10 lines 0 comments Download
M src/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 5 chunks +0 lines, -16 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/oprofile-agent.h View 1 chunk +0 lines, -77 lines 0 comments Download
D src/oprofile-agent.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M src/v8.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/oprofile/annotate View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/oprofile/common View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/oprofile/dump View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/oprofile/report View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/oprofile/reset View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/oprofile/run View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/oprofile/shutdown View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/oprofile/start View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 7 chunks +0 lines, -10 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
9 years, 10 months ago (2011-02-11 12:08:00 UTC) #1
Søren Thygesen Gjesse
LGTM!
9 years, 10 months ago (2011-02-11 12:16:45 UTC) #2
Søren Thygesen Gjesse
Btw. shouldn't the directory tools/oprofile be removed as well?
9 years, 10 months ago (2011-02-11 12:17:31 UTC) #3
mnaganov (inactive)
9 years, 10 months ago (2011-02-11 12:25:13 UTC) #4 
On 2011/02/11 12:17:31, Søren Gjesse wrote:
> Btw. shouldn't the directory tools/oprofile be removed as well?

I believe, it should be. Let's see how git-svn integration works.

Powered by Google App Engine
This is Rietveld 408576698