Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 6474032: mach-tegra: Adding MMC_KEEP_POWER to support suspend/resume for wifi SDIO slot (Closed)

Created:
9 years, 10 months ago by ggg
Modified:
9 years, 7 months ago
Reviewers:
Olof Johansson
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Mandeep Singh Baines
Visibility:
Public.

Description

mach-tegra: Adding MMC_KEEP_POWER to support suspend/resume for wifi SDIO slot Change-Id: Ia1ed50cf44b432dc9bbf51733369c00546225128 Signed-off-by: Venkat Rao <vrao@broadcom.com>; BUG=none TEST=Broadcom Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ac9a15e

Patch Set 1 #

Total comments: 1

Patch Set 2 : always assign pm_cap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M arch/arm/mach-tegra/board-seaboard-sdhci.c View 1 chunk +1 line, -0 lines 0 comments Download
M arch/arm/mach-tegra/include/mach/sdhci.h View 1 chunk +1 line, -0 lines 0 comments Download
M drivers/mmc/host/sdhci-tegra.c View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Olof Johansson
Hi, please separate driver change from board change. http://codereview.chromium.org/6474032/diff/1/drivers/mmc/host/sdhci-tegra.c File drivers/mmc/host/sdhci-tegra.c (right): http://codereview.chromium.org/6474032/diff/1/drivers/mmc/host/sdhci-tegra.c#newcode187 drivers/mmc/host/sdhci-tegra.c:187: if ...
9 years, 9 months ago (2011-03-08 02:36:21 UTC) #1
ggg
On Mon, Mar 7, 2011 at 6:36 PM, <olofj@chromium.org> wrote: > Hi, please separate driver ...
9 years, 9 months ago (2011-03-08 21:20:42 UTC) #2
Olof Johansson
Please upstream the include file and sdhci-tegra piece, the board piece isn't upstreamable just yet ...
9 years, 9 months ago (2011-03-10 00:16:52 UTC) #3
Olof Johansson
9 years, 9 months ago (2011-03-28 18:27:39 UTC) #4
Since the driver pieces are staged for .40, LGTM!

I'll take the board piece through my tegra branch for upstream.

Powered by Google App Engine
This is Rietveld 408576698