src/ia32/full-codegen-ia32.cc - Issue 6474026: Strict mode assignment to undefined reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 6474026: Strict mode assignment to undefined reference. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix presubmit. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index feb84e32753e1b15091ba9f98243225a736df888..870a4b66a5188e9f0b8ff0bb097e1c9b3147541a 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2013,8 +2013,10 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var,

// ecx, and the global object on the stack.

__ mov(ecx, var->name());

__ mov(edx, GlobalObjectOperand());

- Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));

- EmitCallIC(ic, RelocInfo::CODE_TARGET);

+ Handle<Code> ic(Builtins::builtin(

+ is_strict() ? Builtins::StoreIC_Initialize_Strict

+ : Builtins::StoreIC_Initialize));

+ EmitCallIC(ic, RelocInfo::CODE_TARGET_CONTEXT);

} else if (op == Token::INIT_CONST) {

// Like var declarations, const declarations are hoisted to function