Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Side by Side Diff: src/arm/virtual-frame-arm.cc

Issue 6474026: Strict mode assignment to undefined reference. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix presubmit. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 322
323 void VirtualFrame::CallLoadIC(Handle<String> name, RelocInfo::Mode mode) { 323 void VirtualFrame::CallLoadIC(Handle<String> name, RelocInfo::Mode mode) {
324 Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize)); 324 Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize));
325 PopToR0(); 325 PopToR0();
326 SpillAll(); 326 SpillAll();
327 __ mov(r2, Operand(name)); 327 __ mov(r2, Operand(name));
328 CallCodeObject(ic, mode, 0); 328 CallCodeObject(ic, mode, 0);
329 } 329 }
330 330
331 331
332 void VirtualFrame::CallStoreIC(Handle<String> name, bool is_contextual) { 332 void VirtualFrame::CallStoreIC(Handle<String> name,
333 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize)); 333 bool is_contextual,
334 StrictModeFlag strict_mode) {
335 Handle<Code> ic(Builtins::builtin(strict_mode == kStrictMode
336 ? Builtins::StoreIC_Initialize_Strict
337 : Builtins::StoreIC_Initialize));
334 PopToR0(); 338 PopToR0();
339 RelocInfo::Mode mode;
335 if (is_contextual) { 340 if (is_contextual) {
336 SpillAll(); 341 SpillAll();
337 __ ldr(r1, MemOperand(cp, Context::SlotOffset(Context::GLOBAL_INDEX))); 342 __ ldr(r1, MemOperand(cp, Context::SlotOffset(Context::GLOBAL_INDEX)));
343 mode = RelocInfo::CODE_TARGET_CONTEXT;
338 } else { 344 } else {
339 EmitPop(r1); 345 EmitPop(r1);
340 SpillAll(); 346 SpillAll();
347 mode = RelocInfo::CODE_TARGET;
341 } 348 }
342 __ mov(r2, Operand(name)); 349 __ mov(r2, Operand(name));
343 CallCodeObject(ic, RelocInfo::CODE_TARGET, 0); 350 CallCodeObject(ic, mode, 0);
344 } 351 }
345 352
346 353
347 void VirtualFrame::CallKeyedLoadIC() { 354 void VirtualFrame::CallKeyedLoadIC() {
348 Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize)); 355 Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize));
349 PopToR1R0(); 356 PopToR1R0();
350 SpillAll(); 357 SpillAll();
351 CallCodeObject(ic, RelocInfo::CODE_TARGET, 0); 358 CallCodeObject(ic, RelocInfo::CODE_TARGET, 0);
352 } 359 }
353 360
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 break; 832 break;
826 } 833 }
827 ASSERT(register_allocation_map_ == 0); // Not yet implemented. 834 ASSERT(register_allocation_map_ == 0); // Not yet implemented.
828 } 835 }
829 836
830 #undef __ 837 #undef __
831 838
832 } } // namespace v8::internal 839 } } // namespace v8::internal
833 840
834 #endif // V8_TARGET_ARCH_ARM 841 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/virtual-frame-arm.h ('k') | src/assembler.h » ('j') | src/stub-cache.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698