Create a path to deliver SocketStream errors to the renderer.

Create a path to deliver SocketStream errors to the renderer.

This patch overrides SocketStreamDispatcherHost::OnError() to receive
SocketStream errors, and relay them to the renderer via process boundary (IPC),
IPCWebSocketHandleBridge, and WebSocketStreamHandleImpl::Context.

BUG=67662
TEST=none

[Yuta Kitamura, 2011-02-10 21:36:59]

This is Chromium's counterpart of <http://webkit.org/b/54226>. This patch should
be committed *after* a patch in WebKit bug 54226 is merged.

Currently code only. I'm still wondering how to write tests for this patch.

Ukai-san: I think you know this code well. However, if you think of any other
good reviewer(s), feel free to add them.

Yoshino-san and Toyoshima-san: FYI.

http://codereview.chromium.org/6474012/diff/11/chrome/browser/renderer_host/s...
File chrome/browser/renderer_host/socket_stream_host.h (right):

http://codereview.chromium.org/6474012/diff/11/chrome/browser/renderer_host/s...
chrome/browser/renderer_host/socket_stream_host.h:35: static int
SocketIdFromSocketStream(const net::SocketStream* socket);
This was necessary because SocketStreamDispatcherHost::OnError takes |const
net::SocketStream*|.

[ukai, 2011-05-10 08:10:39]

http://codereview.chromium.org/6474012/diff/9001/net/socket_stream/socket_str...
File net/socket_stream/socket_stream_unittest.cc (right):

http://codereview.chromium.org/6474012/diff/9001/net/socket_stream/socket_str...
net/socket_stream/socket_stream_unittest.cc:122: // TODO(yutak): Need to figure
out a way to create SocketStreamEvent
can't we const net::SocketStream* socket in SocketStreamEvent?

http://codereview.chromium.org/6474012/diff/9001/webkit/glue/websocketstreamh...
File webkit/glue/websocketstreamhandle_impl.cc (right):

http://codereview.chromium.org/6474012/diff/9001/webkit/glue/websocketstreamh...
webkit/glue/websocketstreamhandle_impl.cc:150: error_code,
when error_code is translated in WebKit's code?
we'll use the same error code in net/base/net_errors.h on all other platform in
WebKit?

[Yuta Kitamura, 2011-05-10 09:01:22]

http://codereview.chromium.org/6474012/diff/9001/net/socket_stream/socket_str...
File net/socket_stream/socket_stream_unittest.cc (right):

http://codereview.chromium.org/6474012/diff/9001/net/socket_stream/socket_str...
net/socket_stream/socket_stream_unittest.cc:122: // TODO(yutak): Need to figure
out a way to create SocketStreamEvent
No, because there are several uses of non-const member functions such as
|event->socket->SendData()| or |event->socket->Close()|.

http://codereview.chromium.org/6474012/diff/9001/webkit/glue/websocketstreamh...
File webkit/glue/websocketstreamhandle_impl.cc (right):

http://codereview.chromium.org/6474012/diff/9001/webkit/glue/websocketstreamh...
webkit/glue/websocketstreamhandle_impl.cc:150: error_code,
In WebKit, SocketStreamError's errorCode is considered platform-dependent. The
only purpose is to show it to users via Web Inspector.

For example, SocketStreamHandleCFNet uses error code returned from
CFErrorGetCode.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/cf/Socke...

[ukai, 2011-05-10 10:00:29]

http://codereview.chromium.org/6474012/diff/9001/net/socket_stream/socket_str...
File net/socket_stream/socket_stream_unittest.cc (right):

http://codereview.chromium.org/6474012/diff/9001/net/socket_stream/socket_str...
net/socket_stream/socket_stream_unittest.cc:122: // TODO(yutak): Need to figure
out a way to create SocketStreamEvent
On 2011/05/10 09:01:22, Yuta Kitamura wrote:
> No, because there are several uses of non-const member functions such as
> |event->socket->SendData()| or |event->socket->Close()|.

Hmm. then I think SocketStreamEvent should have net::SocketStream* and const
net::SocketStream*.

or it might be ok to change OnError passes non-const net::SocketStream*.

http://codereview.chromium.org/6474012/diff/9001/webkit/glue/websocketstreamh...
File webkit/glue/websocketstreamhandle_impl.cc (right):

http://codereview.chromium.org/6474012/diff/9001/webkit/glue/websocketstreamh...
webkit/glue/websocketstreamhandle_impl.cc:150: error_code,
On 2011/05/10 09:01:22, Yuta Kitamura wrote:
> In WebKit, SocketStreamError's errorCode is considered platform-dependent. The
> only purpose is to show it to users via Web Inspector.
> 
> For example, SocketStreamHandleCFNet uses error code returned from
> CFErrorGetCode.
>
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/cf/Socke...

Hmm. then I think we should refrain from using errorCode in message to web
developer (as ResourceError)