Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4760)

Unified Diff: chrome/browser/icon_manager_linux.cc

Issue 6473004: Suppress IO-on-wrong-thread DCHECK during file downloads.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/icon_manager_linux.cc
===================================================================
--- chrome/browser/icon_manager_linux.cc (revision 74649)
+++ chrome/browser/icon_manager_linux.cc (working copy)
@@ -5,7 +5,15 @@
#include "chrome/browser/icon_manager.h"
#include "base/mime_util.h"
+#include "base/threading/thread_restrictions.h"
IconGroupID IconManager::GetGroupIDFromFilepath(const FilePath& filepath) {
+ // It turns out the call to mime_util::GetFileMimeType below does IO, but
+ // callers of GetGroupIDFromFilepath assume it does not do IO (the Windows
+ // and Mac implementations do not). We should fix this by either not doing IO
+ // in this method, or reworking callers to avoid calling it on the UI thread.
+ // See crbug.com/72740.
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
+
return mime_util::GetFileMimeType(filepath);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698