Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 6472001: Fix forging of object's identity hashes. (Closed)

Created:
9 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix forging of object's identity hashes. Do not do standard property lookup on hidden properties object as it might reach Object.prototype which can be altered to forge identity hashes. Instead do only local lookup. Committed: http://code.google.com/p/v8/source/detail?r=6728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M src/api.cc View 1 chunk +31 lines, -19 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, a review for you.
9 years, 10 months ago (2011-02-09 19:15:25 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-10 10:14:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698