Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 6471021: Strengthen requirements for fixed registers at calls.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 ASSERT(double_register_spills_[allocation_index] == NULL); 67 ASSERT(double_register_spills_[allocation_index] == NULL);
68 double_register_spills_[allocation_index] = spill_operand; 68 double_register_spills_[allocation_index] = spill_operand;
69 } 69 }
70 70
71 71
72 #ifdef DEBUG 72 #ifdef DEBUG
73 void LInstruction::VerifyCall() { 73 void LInstruction::VerifyCall() {
74 // Call instructions can use only fixed registers as 74 // Call instructions can use only fixed registers as
75 // temporaries and outputs because all registers 75 // temporaries and outputs because all registers
76 // are blocked by the calling convention. 76 // are blocked by the calling convention.
77 // Inputs can use either fixed register or have a short lifetime (be 77 // Inputs must use a fixed register.
78 // used at start of the instruction).
79 ASSERT(Output() == NULL || 78 ASSERT(Output() == NULL ||
80 LUnallocated::cast(Output())->HasFixedPolicy() || 79 LUnallocated::cast(Output())->HasFixedPolicy() ||
81 !LUnallocated::cast(Output())->HasRegisterPolicy()); 80 !LUnallocated::cast(Output())->HasRegisterPolicy());
82 for (UseIterator it(this); it.HasNext(); it.Advance()) { 81 for (UseIterator it(this); it.HasNext(); it.Advance()) {
83 LOperand* operand = it.Next(); 82 LOperand* operand = it.Next();
84 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() || 83 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() ||
85 LUnallocated::cast(operand)->IsUsedAtStart() ||
86 !LUnallocated::cast(operand)->HasRegisterPolicy()); 84 !LUnallocated::cast(operand)->HasRegisterPolicy());
87 } 85 }
88 for (TempIterator it(this); it.HasNext(); it.Advance()) { 86 for (TempIterator it(this); it.HasNext(); it.Advance()) {
89 LOperand* operand = it.Next(); 87 LOperand* operand = it.Next();
90 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() || 88 ASSERT(LUnallocated::cast(operand)->HasFixedPolicy() ||
91 !LUnallocated::cast(operand)->HasRegisterPolicy()); 89 !LUnallocated::cast(operand)->HasRegisterPolicy());
92 } 90 }
93 } 91 }
94 #endif 92 #endif
95 93
(...skipping 1760 matching lines...) Expand 10 before | Expand all | Expand 10 after
1856 1854
1857 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 1855 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
1858 HEnvironment* outer = current_block_->last_environment()->outer(); 1856 HEnvironment* outer = current_block_->last_environment()->outer();
1859 current_block_->UpdateEnvironment(outer); 1857 current_block_->UpdateEnvironment(outer);
1860 return NULL; 1858 return NULL;
1861 } 1859 }
1862 1860
1863 } } // namespace v8::internal 1861 } } // namespace v8::internal
1864 1862
1865 #endif // V8_TARGET_ARCH_X64 1863 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698