Issue 647022: Add maxStrinLength argument to debugger requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647022: Add maxStrinLength argument to debugger requests (Closed)

Created:
10 years, 10 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev, pfeldman

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add maxStrinLength argument to debugger requests Committed: http://code.google.com/p/v8/source/detail?r=3919

Patch Set 4 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -16 lines)			Patch
M	src/debug-delay.js	View	1 2 3	1 chunk	+10 lines, -5 lines	0 comments	Download
M	src/mirror-delay.js	View	1 2 3	4 chunks	+22 lines, -11 lines	0 comments	Download
M	test/mjsunit/debug-evaluate.js	View	1 2 3	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/647022/diff/9/1005 File test/mjsunit/debug-evaluate.js (right): http://codereview.chromium.org/647022/diff/9/1005#newcode94 test/mjsunit/debug-evaluate.js:94: '{"expression":"this.longString","global":true, maxStringLength:-1}', Please remove the space before maxStringLength ...

10 years, 10 months ago (2010-02-19 13:42:20 UTC) #2

yurys

10 years, 10 months ago (2010-02-19 14:32:31 UTC) #3

http://codereview.chromium.org/647022/diff/9/1005
File test/mjsunit/debug-evaluate.js (right):

http://codereview.chromium.org/647022/diff/9/1005#newcode94
test/mjsunit/debug-evaluate.js:94:
'{"expression":"this.longString","global":true, maxStringLength:-1}',
On 2010/02/19 13:42:21, Søren Gjesse wrote:
> Please remove the space before maxStringLength for consistency.

Done.

http://codereview.chromium.org/647022/diff/9/1005#newcode102
test/mjsunit/debug-evaluate.js:102: longString);
On 2010/02/19 13:42:21, Søren Gjesse wrote:
> How about adding a test with maxStringLength of 0, 1, and 80 as well?

Done.

Expand Messages | Collapse Messages

Issue 647022: Add maxStrinLength argument to debugger requests (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages