Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 647018: Introduce 'trivial' expressions, use them for this property assignments. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce 'trivial' expressions, use them for this property assignments. Add a (currently) syntactic predicate to AST expression nodes telling whether they are 'trivial'. Trivial expressions have no side effects, do not require storage to be allocated for them, and can be evaluated out of order (because their value does not change between when they are visited by the code generator as expressions in the AST and when it is consumed). Mark 'this' and literals as trivial. Allow them to be pushed on the virtual frame. Make use of them to push 'this' more lazily in this property assignments. Committed: http://code.google.com/p/v8/source/detail?r=3906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -13 lines) Patch
M src/ast.h View 4 chunks +10 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 4 chunks +32 lines, -12 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 10 months ago (2010-02-18 14:30:50 UTC) #1
fschneider
10 years, 10 months ago (2010-02-19 00:58:10 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698