Issue 647016: importer: use FilePath instead of wstring in some places

Issue 647016: importer: use FilePath instead of wstring in some places (Closed)

Created:
10 years, 10 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, tony

CC:
chromium-reviews_googlegroups.com, kuchhal, brettw+cc_chromium.org, ben+cc_chromium.org, pam+watch_chromium.org, darin+cc_chromium.org, dpranke+watch_chromium.org, jam, Paweł Hajdan Jr.

Visibility:
Public.

Description

importer: use FilePath instead of wstring in some places Added API to DictionaryValue to use ASCII where appropriate. BUG=24672 TEST=profile import still got my bookmarks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39441

Patch Set 1 #

Patch Set 2 : better comment #

Total comments: 4

Patch Set 3 : with fixes #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -28 lines)			Patch
M	base/values.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	base/values.cc	View	1 2	2 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_utils.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_utils.cc	View	1	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/importer/importer_list.cc	View	1 2	4 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

(for more context, I'm trying to remove file_util::AppendToPath(wstring, wstring), and this was one of the ...

10 years, 10 months ago (2010-02-18 13:39:09 UTC) #2

Mark Mentovai

lgtm http://codereview.chromium.org/647016/diff/12/1002 File base/values.h (right): http://codereview.chromium.org/647016/diff/12/1002#newcode218 base/values.h:218: // Deprecated version of the above. TODO: add ...

10 years, 10 months ago (2010-02-18 17:21:46 UTC) #3

tony

10 years, 10 months ago (2010-02-19 04:13:56 UTC) #4

http://codereview.chromium.org/647016/diff/12/1002
File base/values.h (right):

http://codereview.chromium.org/647016/diff/12/1002#newcode217
base/values.h:217: bool HasKey(const std::string& key) const;
Nit: Should this have ascii in the name to make it obvious?  Someone is going to
try to pass in a FilePath::value() here on Linux/Mac.

http://codereview.chromium.org/647016/diff/12/1002#newcode270
base/values.h:270: bool GetStringASCII(const std::string& path, std::string*
out_value) const;
This method expects ascii for |path| but returns utf8 in |out_value|.  This
seems dangerous to me.

I'm sorry we didn't tighten down the use of std::string in this file earlier. :(

Expand Messages | Collapse Messages