src/ia32/stub-cache-ia32.cc - Issue 647015: Remove the LookupResult IsValid method because it is confusing....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 647015: Remove the LookupResult IsValid method because it is confusing.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

===================================================================

--- src/ia32/stub-cache-ia32.cc (revision 3900)

+++ src/ia32/stub-cache-ia32.cc (working copy)

@@ -323,7 +323,7 @@

stub_compiler->CheckPrototypes(object, receiver, holder,

scratch1, scratch2, name, miss);

- if (lookup->IsValid() && lookup->IsCacheable()) {

+ if (lookup->IsProperty() && lookup->IsCacheable()) {

compiler->CompileCacheable(masm,

stub_compiler,

receiver,

@@ -484,7 +484,7 @@

is_simple_api_call_(false),

expected_receiver_type_(NULL),

api_call_info_(NULL) {

- if (!lookup->IsValid() || !lookup->IsCacheable()) return;

+ if (!lookup->IsProperty() || !lookup->IsCacheable()) return;

// We only optimize constant function calls.

if (lookup->type() != CONSTANT_FUNCTION) return;

« no previous file with comments | « src/fast-codegen.cc ('k') | src/ic.cc » ('j') | no next file with comments »