Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 647015: Remove the LookupResult IsValid method because it is confusing.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 ASSERT(!holder->GetNamedInterceptor()->getter()->IsUndefined()); 392 ASSERT(!holder->GetNamedInterceptor()->getter()->IsUndefined());
393 393
394 // Check that the receiver isn't a smi. 394 // Check that the receiver isn't a smi.
395 __ JumpIfSmi(receiver, miss); 395 __ JumpIfSmi(receiver, miss);
396 396
397 // Check that the maps haven't changed. 397 // Check that the maps haven't changed.
398 Register reg = 398 Register reg =
399 stub_compiler->CheckPrototypes(object, receiver, holder, 399 stub_compiler->CheckPrototypes(object, receiver, holder,
400 scratch1, scratch2, name, miss); 400 scratch1, scratch2, name, miss);
401 401
402 if (lookup->IsValid() && lookup->IsCacheable()) { 402 if (lookup->IsProperty() && lookup->IsCacheable()) {
403 compiler->CompileCacheable(masm, 403 compiler->CompileCacheable(masm,
404 stub_compiler, 404 stub_compiler,
405 receiver, 405 receiver,
406 reg, 406 reg,
407 scratch1, 407 scratch1,
408 scratch2, 408 scratch2,
409 holder, 409 holder,
410 lookup, 410 lookup,
411 name, 411 name,
412 miss); 412 miss);
(...skipping 1440 matching lines...) Expand 10 before | Expand all | Expand 10 after
1853 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET); 1853 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET);
1854 1854
1855 // Return the generated code. 1855 // Return the generated code.
1856 return GetCode(); 1856 return GetCode();
1857 } 1857 }
1858 1858
1859 1859
1860 #undef __ 1860 #undef __
1861 1861
1862 } } // namespace v8::internal 1862 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698