Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/stub-cache.cc

Issue 647015: Remove the LookupResult IsValid method because it is confusing.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1052 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 } 1063 }
1064 1064
1065 1065
1066 Object* StubCompiler::GetCodeWithFlags(Code::Flags flags, String* name) { 1066 Object* StubCompiler::GetCodeWithFlags(Code::Flags flags, String* name) {
1067 if (FLAG_print_code_stubs && (name != NULL)) { 1067 if (FLAG_print_code_stubs && (name != NULL)) {
1068 return GetCodeWithFlags(flags, *name->ToCString()); 1068 return GetCodeWithFlags(flags, *name->ToCString());
1069 } 1069 }
1070 return GetCodeWithFlags(flags, reinterpret_cast<char*>(NULL)); 1070 return GetCodeWithFlags(flags, reinterpret_cast<char*>(NULL));
1071 } 1071 }
1072 1072
1073
1073 void StubCompiler::LookupPostInterceptor(JSObject* holder, 1074 void StubCompiler::LookupPostInterceptor(JSObject* holder,
1074 String* name, 1075 String* name,
1075 LookupResult* lookup) { 1076 LookupResult* lookup) {
1076 holder->LocalLookupRealNamedProperty(name, lookup); 1077 holder->LocalLookupRealNamedProperty(name, lookup);
1077 if (lookup->IsNotFound()) { 1078 if (!lookup->IsProperty()) {
1079 lookup->NotFound();
1078 Object* proto = holder->GetPrototype(); 1080 Object* proto = holder->GetPrototype();
1079 if (proto != Heap::null_value()) { 1081 if (proto != Heap::null_value()) {
1080 proto->Lookup(name, lookup); 1082 proto->Lookup(name, lookup);
1081 } 1083 }
1082 } 1084 }
1083 } 1085 }
1084 1086
1085 1087
1086 1088
1087 Object* LoadStubCompiler::GetCode(PropertyType type, String* name) { 1089 Object* LoadStubCompiler::GetCode(PropertyType type, String* name) {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 if (!result->IsFailure()) { 1126 if (!result->IsFailure()) {
1125 Code* code = Code::cast(result); 1127 Code* code = Code::cast(result);
1126 USE(code); 1128 USE(code);
1127 LOG(CodeCreateEvent(Logger::STUB_TAG, code, "ConstructStub")); 1129 LOG(CodeCreateEvent(Logger::STUB_TAG, code, "ConstructStub"));
1128 } 1130 }
1129 return result; 1131 return result;
1130 } 1132 }
1131 1133
1132 1134
1133 } } // namespace v8::internal 1135 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698