Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: src/property.cc

Issue 647015: Remove the LookupResult IsValid method because it is confusing.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/property.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 15 matching lines...) Expand all
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "v8.h" 28 #include "v8.h"
29 29
30 namespace v8 { 30 namespace v8 {
31 namespace internal { 31 namespace internal {
32 32
33 33
34 #ifdef DEBUG 34 #ifdef DEBUG
35 void LookupResult::Print() { 35 void LookupResult::Print() {
36 if (!IsValid()) { 36 if (!IsFound()) {
37 PrintF("Not Found\n"); 37 PrintF("Not Found\n");
38 return; 38 return;
39 } 39 }
40 40
41 PrintF("LookupResult:\n"); 41 PrintF("LookupResult:\n");
42 PrintF(" -cacheable = %s\n", IsCacheable() ? "true" : "false"); 42 PrintF(" -cacheable = %s\n", IsCacheable() ? "true" : "false");
43 PrintF(" -attributes = %x\n", GetAttributes()); 43 PrintF(" -attributes = %x\n", GetAttributes());
44 switch (type()) { 44 switch (type()) {
45 case NORMAL: 45 case NORMAL:
46 PrintF(" -type = normal\n"); 46 PrintF(" -type = normal\n");
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 PrintF(" @ "); 87 PrintF(" @ ");
88 GetValue()->ShortPrint(); 88 GetValue()->ShortPrint();
89 PrintF(" %d\n", GetDetails().index()); 89 PrintF(" %d\n", GetDetails().index());
90 } 90 }
91 91
92 92
93 #endif 93 #endif
94 94
95 95
96 } } // namespace v8::internal 96 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/property.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698