Remove the LookupResult IsValid method because it is confusing....

src/fast-codegen.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 202 matching lines @@
 
 void FastCodeGenSyntaxChecker::VisitVariableProxy(VariableProxy* expr) {
   // Only global variable references are supported.
   Variable* var = expr->var();
   if (!var->is_global() || var->is_this()) BAILOUT("Non-global variable");
 
   // Check if the global variable is existing and non-deletable.
   if (info()->has_global_object()) {
     LookupResult lookup;
     info()->global_object()->Lookup(*expr->name(), &lookup);
-    if (!lookup.IsValid()) {
+    if (!lookup.IsProperty()) {
       BAILOUT("Non-existing global variable");
     }
     // We do not handle global variables with accessors or interceptors.
     if (lookup.type() != NORMAL) {
       BAILOUT("Global variable with accessors or interceptors.");
     }
     // We do not handle deletable global variables.
     if (!lookup.IsDontDelete()) {
       BAILOUT("Deletable global variable");
     }
@@ skipping 43 matching lines @@
 
   // We will only specialize for fields on the object itself.
   // Expression::IsPropertyName implies that the name is a literal
   // symbol but we do not assume that.
   Literal* key = prop->key()->AsLiteral();
   if (key != NULL && key->handle()->IsString()) {
     Handle<Object> receiver = info()->receiver();
     Handle<String> name = Handle<String>::cast(key->handle());
     LookupResult lookup;
     receiver->Lookup(*name, &lookup);
-    if (!lookup.IsValid()) {
+    if (!lookup.IsProperty()) {
       BAILOUT("Assigned property not found at compile time");
     }
     if (lookup.holder() != *receiver) BAILOUT("Non-own property assignment");
     if (!lookup.type() == FIELD) BAILOUT("Non-field property assignment");
   } else {
     UNREACHABLE();
     BAILOUT("Unexpected non-string-literal property key");
   }
 
   Visit(expr->value());
@@ skipping 17 matching lines @@
 
   // We will only specialize for fields on the object itself.
   // Expression::IsPropertyName implies that the name is a literal
   // symbol but we do not assume that.
   Literal* key = expr->key()->AsLiteral();
   if (key != NULL && key->handle()->IsString()) {
     Handle<Object> receiver = info()->receiver();
     Handle<String> name = Handle<String>::cast(key->handle());
     LookupResult lookup;
     receiver->Lookup(*name, &lookup);
-    if (!lookup.IsValid()) {
+    if (!lookup.IsProperty()) {
       BAILOUT("Referenced property not found at compile time");
     }
     if (lookup.holder() != *receiver) BAILOUT("Non-own property reference");
     if (!lookup.type() == FIELD) BAILOUT("Non-field property reference");
   } else {
     UNREACHABLE();
     BAILOUT("Unexpected non-string-literal property key");
   }
 }
 
@@ skipping 243 matching lines @@
 
 
 void FastCodeGenerator::VisitVariableProxy(VariableProxy* expr) {
   ASSERT(expr->var()->is_global() && !expr->var()->is_this());
   // Check if we can compile a global variable load directly from the cell.
   ASSERT(info()->has_global_object());
   LookupResult lookup;
   info()->global_object()->Lookup(*expr->name(), &lookup);
   // We only support normal (non-accessor/interceptor) DontDelete properties
   // for now.
-  ASSERT(lookup.IsValid());
+  ASSERT(lookup.IsProperty());
   ASSERT_EQ(NORMAL, lookup.type());
   ASSERT(lookup.IsDontDelete());
   Handle<Object> cell(info()->global_object()->GetPropertyCell(&lookup));
 
   // Global variable lookups do not have side effects, so we do not need to
   // emit code if we are in an effect context.
   if (!destination().is(no_reg)) {
     Comment cmnt(masm(), ";; Global");
     if (FLAG_print_ir) {
       SmartPointer<char> name = expr->name()->ToCString();
@@ skipping 141 matching lines @@
 
 
 void FastCodeGenerator::VisitThisFunction(ThisFunction* expr) {
   UNREACHABLE();
 }
 
 #undef __
 
 
 } }  // namespace v8::internal