Make setting length on arrays faster.

Make setting length on arrays faster.

Committed: http://code.google.com/p/v8/source/detail?r=3902

[antonm, 2010-02-18 11:42:55]

Mads,

may you have a look?

[Kevin Millikin (Chromium), 2010-02-18 12:08:31]

Some small comments.

http://codereview.chromium.org/647013/diff/1/4
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/647013/diff/1/4#newcode1468
src/ia32/ic-ia32.cc:1468: Register receiver = edx;
Make these const Register.

http://codereview.chromium.org/647013/diff/1/4#newcode1500
src/ia32/ic-ia32.cc:1500: // Prepare tail call to StoreIC_Miss
This whole code snippet is

GenerateMiss(masm);

http://codereview.chromium.org/647013/diff/1/5
File src/ic.cc (right):

http://codereview.chromium.org/647013/diff/1/5#newcode1360
src/ic.cc:1360: Object* StoreIC_ArrayLength(Arguments args) {
Please put NoHandleAllocation in this function, and ASSERT that the args length
is as expected.

[antonm, 2010-02-18 12:27:55]

Thanks a lot, Kevin.

On 2010/02/18 12:08:31, Kevin Millikin wrote:
> Some small comments.
> 
> http://codereview.chromium.org/647013/diff/1/4
> File src/ia32/ic-ia32.cc (right):
> 
> http://codereview.chromium.org/647013/diff/1/4#newcode1468
> src/ia32/ic-ia32.cc:1468: Register receiver = edx;
> Make these const Register.
> 
> http://codereview.chromium.org/647013/diff/1/4#newcode1500
> src/ia32/ic-ia32.cc:1500: // Prepare tail call to StoreIC_Miss
> This whole code snippet is
> 
> GenerateMiss(masm);
> 
> http://codereview.chromium.org/647013/diff/1/5
> File src/ic.cc (right):
> 
> http://codereview.chromium.org/647013/diff/1/5#newcode1360
> src/ic.cc:1360: Object* StoreIC_ArrayLength(Arguments args) {
> Please put NoHandleAllocation in this function, and ASSERT that the args
length
> is as expected.

[antonm, 2010-02-18 12:32:41]

Forgotten responses.  And I'd do port to other platforms if it's lgtm.

http://codereview.chromium.org/647013/diff/1/4
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/647013/diff/1/4#newcode1500
src/ia32/ic-ia32.cc:1500: // Prepare tail call to StoreIC_Miss
On 2010/02/18 12:08:31, Kevin Millikin wrote:
> This whole code snippet is
> 
> GenerateMiss(masm);

Oh yes, I am an idiot, thanks a lot for spotting this.

http://codereview.chromium.org/647013/diff/1/5
File src/ic.cc (right):

http://codereview.chromium.org/647013/diff/1/5#newcode1360
src/ic.cc:1360: Object* StoreIC_ArrayLength(Arguments args) {
On 2010/02/18 12:08:31, Kevin Millikin wrote:
> Please put NoHandleAllocation in this function, and ASSERT that the args
length
> is as expected.

Done.

[Kevin Millikin (Chromium), 2010-02-18 12:45:19]

LGTM, with ports to the other two platform.

http://codereview.chromium.org/647013/diff/1010/14
File src/builtins.h (right):

http://codereview.chromium.org/647013/diff/1010/14#newcode99
src/builtins.h:99: V(StoreIC_ArrayLength,        STORE_IC, MONOMORPHIC)         
          \
MEGAMORPHIC?

[antonm, 2010-02-18 16:54:21]

Kevin, Mads, port is done.  I'm going to submit after I run the tests, if you
have any comment, please, let me know---I think in this CL or another one.

[Mads Ager (chromium), 2010-02-19 09:46:58]

LGTM