Added access check to SetNormalizedProperty which is used from runtime Define...

Added access check to SetNormalizedProperty which is used from runtime DefineOrRedefineDataProperty. 


Committed: http://code.google.com/p/v8/source/detail?r=3900

[Rico, 2010-02-18 11:15:55]

Test (LayoutTest: http/tests/security/xss-DENIED-defineProperty) still fails but
with "Unexpected text diff mismatch" (the expected result has way less access
denied printouts then the output from us)

[antonm, 2010-02-18 11:48:26]

Drive-by question

http://codereview.chromium.org/647010/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/647010/diff/1/2#newcode420
src/objects.cc:420: if (IsAccessCheckNeeded() &&
just for my education: is it fine to perform check here?  shouldn't it be
performed earlier?

[Rico, 2010-02-18 12:59:04]

Anton:
You are right - this should be done earlier since it is already done in other
methods that call this one.

I changed the solution completely - adding propertydetails to the call to
SetNormalizedProperty from IgnoreAttributesAndSetLocalProperty (we cannot use
SetProperty as this will not set the property if the writable is false) and call
this instead of the SetNormalizedProperty in DefineOrRedefineDataProperty.

[Mads Ager (chromium), 2010-02-18 13:03:42]

LGTM

http://codereview.chromium.org/647010/diff/1005/10
File src/runtime.cc (right):

http://codereview.chromium.org/647010/diff/1005/10#newcode2932
src/runtime.cc:2932: // overridden (and SetProperty does not allow this
Remove '(' and add period at end of comment?

[Rico, 2010-02-18 13:09:59]

http://codereview.chromium.org/647010/diff/1005/10
File src/runtime.cc (right):

http://codereview.chromium.org/647010/diff/1005/10#newcode2932
src/runtime.cc:2932: // overridden (and SetProperty does not allow this
On 2010/02/18 13:03:43, Mads Ager wrote:
> Remove '(' and add period at end of comment?

Done.