Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 6469083: Fix for bug http://code.google.com/p/v8/issues/detail?id=1176. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixing comments.wq Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3355 matching lines...) Expand 10 before | Expand all | Expand 10 after
3366 } else { 3366 } else {
3367 VisitForStackValue(prop->obj()); 3367 VisitForStackValue(prop->obj());
3368 VisitForStackValue(prop->key()); 3368 VisitForStackValue(prop->key());
3369 __ mov(r1, Operand(Smi::FromInt(strict_mode_flag()))); 3369 __ mov(r1, Operand(Smi::FromInt(strict_mode_flag())));
3370 __ push(r1); 3370 __ push(r1);
3371 __ InvokeBuiltin(Builtins::DELETE, CALL_JS); 3371 __ InvokeBuiltin(Builtins::DELETE, CALL_JS);
3372 context()->Plug(r0); 3372 context()->Plug(r0);
3373 } 3373 }
3374 } else if (var != NULL) { 3374 } else if (var != NULL) {
3375 // Delete of an unqualified identifier is disallowed in strict mode 3375 // Delete of an unqualified identifier is disallowed in strict mode
3376 // so this code can only be reached in non-strict mode. 3376 // but "delete this" is.
3377 ASSERT(strict_mode_flag() == kNonStrictMode); 3377 ASSERT(strict_mode_flag() == kNonStrictMode || var->is_this());
3378 if (var->is_global()) { 3378 if (var->is_global()) {
3379 __ ldr(r2, GlobalObjectOperand()); 3379 __ ldr(r2, GlobalObjectOperand());
3380 __ mov(r1, Operand(var->name())); 3380 __ mov(r1, Operand(var->name()));
3381 __ mov(r0, Operand(Smi::FromInt(kNonStrictMode))); 3381 __ mov(r0, Operand(Smi::FromInt(kNonStrictMode)));
3382 __ Push(r2, r1, r0); 3382 __ Push(r2, r1, r0);
3383 __ InvokeBuiltin(Builtins::DELETE, CALL_JS); 3383 __ InvokeBuiltin(Builtins::DELETE, CALL_JS);
3384 context()->Plug(r0); 3384 context()->Plug(r0);
3385 } else if (var->AsSlot() != NULL && 3385 } else if (var->AsSlot() != NULL &&
3386 var->AsSlot()->type() != Slot::LOOKUP) { 3386 var->AsSlot()->type() != Slot::LOOKUP) {
3387 // Result of deleting non-global, non-dynamic variables is false. 3387 // Result of deleting non-global, non-dynamic variables is false.
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
4025 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 4025 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
4026 __ add(pc, r1, Operand(masm_->CodeObject())); 4026 __ add(pc, r1, Operand(masm_->CodeObject()));
4027 } 4027 }
4028 4028
4029 4029
4030 #undef __ 4030 #undef __
4031 4031
4032 } } // namespace v8::internal 4032 } } // namespace v8::internal
4033 4033
4034 #endif // V8_TARGET_ARCH_ARM 4034 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698