Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 6469083: Fix for bug http://code.google.com/p/v8/issues/detail?id=1176. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixing comments.wq Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5832 matching lines...) Expand 10 before | Expand all | Expand 10 after
5843 Variable* variable = node->expression()->AsVariableProxy()->AsVariable(); 5843 Variable* variable = node->expression()->AsVariableProxy()->AsVariable();
5844 if (property != NULL) { 5844 if (property != NULL) {
5845 Load(property->obj()); 5845 Load(property->obj());
5846 Load(property->key()); 5846 Load(property->key());
5847 frame_->EmitPush(Operand(Smi::FromInt(strict_mode_flag()))); 5847 frame_->EmitPush(Operand(Smi::FromInt(strict_mode_flag())));
5848 frame_->InvokeBuiltin(Builtins::DELETE, CALL_JS, 3); 5848 frame_->InvokeBuiltin(Builtins::DELETE, CALL_JS, 3);
5849 frame_->EmitPush(r0); 5849 frame_->EmitPush(r0);
5850 5850
5851 } else if (variable != NULL) { 5851 } else if (variable != NULL) {
5852 // Delete of an unqualified identifier is disallowed in strict mode 5852 // Delete of an unqualified identifier is disallowed in strict mode
5853 // so this code can only be reached in non-strict mode. 5853 // but "delete this" is.
5854 ASSERT(strict_mode_flag() == kNonStrictMode); 5854 ASSERT(strict_mode_flag() == kNonStrictMode || variable->is_this());
5855 Slot* slot = variable->AsSlot(); 5855 Slot* slot = variable->AsSlot();
5856 if (variable->is_global()) { 5856 if (variable->is_global()) {
5857 LoadGlobal(); 5857 LoadGlobal();
5858 frame_->EmitPush(Operand(variable->name())); 5858 frame_->EmitPush(Operand(variable->name()));
5859 frame_->EmitPush(Operand(Smi::FromInt(kNonStrictMode))); 5859 frame_->EmitPush(Operand(Smi::FromInt(kNonStrictMode)));
5860 frame_->InvokeBuiltin(Builtins::DELETE, CALL_JS, 3); 5860 frame_->InvokeBuiltin(Builtins::DELETE, CALL_JS, 3);
5861 frame_->EmitPush(r0); 5861 frame_->EmitPush(r0);
5862 5862
5863 } else if (slot != NULL && slot->type() == Slot::LOOKUP) { 5863 } else if (slot != NULL && slot->type() == Slot::LOOKUP) {
5864 // Delete from the context holding the named variable. 5864 // Delete from the context holding the named variable.
(...skipping 1510 matching lines...) Expand 10 before | Expand all | Expand 10 after
7375 BinaryOpIC::GetName(runtime_operands_type_)); 7375 BinaryOpIC::GetName(runtime_operands_type_));
7376 return name_; 7376 return name_;
7377 } 7377 }
7378 7378
7379 7379
7380 #undef __ 7380 #undef __
7381 7381
7382 } } // namespace v8::internal 7382 } } // namespace v8::internal
7383 7383
7384 #endif // V8_TARGET_ARCH_ARM 7384 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698