Fix for bug http://code.google.com/p/v8/issues/detail?id=1176.

Fix for bug http://code.google.com/p/v8/issues/detail?id=1176.

Updated the assert assumption of which was not correct with
respect to "delete this".

BUG=http://code.google.com/p/v8/issues/detail?id=1176.
TEST=test/mjsunit/regress/regress-1176.js

[Martin Maly, 2011-02-21 20:18:36]

Fix for bug 1176. An invalid assumption in the assert.

http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:8238: ASSERT(strict_mode_flag() == kNonStrictMode ||
variable->is_this());
It is not the absolutely most paranoid version of the assert one can come up
with. Strictly speaking, only 1 branches out of the 3 below can see "this" but I
feel this assert is quite adequate for the purpose it serves. Alternative would
be to litter the code with 2 more asserts and more comments.
I believe this strikes the right balance.

http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:8260: frame_->Push(Factory::false_value());
aligning the code layout of ia32, x64 and arm codegens, they were inconsistent.

[Mads Ager (chromium), 2011-02-22 07:42:28]

LGTM

http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:3376: // (but "delete this" is).
Remove the parenthesis? 

but "delete this" is allowed.

http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:8260: frame_->Push(Factory::false_value());
On 2011/02/21 20:18:36, Martin Maly wrote:
> aligning the code layout of ia32, x64 and arm codegens, they were
inconsistent.

Thanks.

[Martin Maly, 2011-02-22 17:21:42]

Done. Thanks!

http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:3376: // (but "delete this" is).
On 2011/02/22 07:42:28, Mads Ager wrote:
> Remove the parenthesis? 
> 
> but "delete this" is allowed.

Done.