Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 6469072: [login_manager] Use keygen helper to generate owner key (Closed)

Created:
9 years, 10 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
Will Drewry
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

[login_manager] Use keygen helper to generate owner key Generates the owner key in the session manager, and deprecates SetOwnerKey. The change which makes Chrome savvy to this is at http://codereview.chromium.org/6538098/ In the window between landing this and landing the chrome change (which I will try to minimize), ownership will be taken successfully on first login, but the user won't be able to do owner-things (whitelisting, turning off guest mode, etc) until his second login. Once the chrome change lands as well, this issue will go away. BUG=9608 TEST=unit, smoke suite, and also OwnershipTaken and OwnershipNotRetaken autotests Change-Id: I08504966d9e682f181b317837299cbf6c07c6ecc Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=78fe078

Patch Set 1 #

Patch Set 2 : Add a few constants #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -145 lines) Patch
M mock_owner_key.h View 1 chunk +1 line, -0 lines 0 comments Download
M nss_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M nss_util.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M owner_key.h View 2 chunks +4 lines, -0 lines 0 comments Download
M owner_key.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M session_manager_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M session_manager_service.h View 1 7 chunks +24 lines, -4 lines 0 comments Download
M session_manager_service.cc View 1 7 chunks +93 lines, -50 lines 1 comment Download
M session_manager_unittest.cc View 1 17 chunks +76 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Masone
PTAL, when you get a chance. Still have to do the chrome side of this.
9 years, 10 months ago (2011-02-20 01:17:46 UTC) #1
Chris Masone
Ping? On 2011/02/20 01:17:46, Chris Masone wrote: > PTAL, when you get a chance. Still ...
9 years, 10 months ago (2011-02-23 03:04:20 UTC) #2
Will Drewry
LGTM with one question! This is surprisingly clean :) http://codereview.chromium.org/6469072/diff/2001/session_manager_service.cc File session_manager_service.cc (right): http://codereview.chromium.org/6469072/diff/2001/session_manager_service.cc#newcode558 session_manager_service.cc:558: ...
9 years, 10 months ago (2011-02-23 03:30:16 UTC) #3
Chris Masone
9 years, 10 months ago (2011-02-23 04:07:49 UTC) #4
On Feb 22, 2011 7:30 PM, <wad@chromium.org> wrote:
>
> LGTM with one question!
>
> This is surprisingly clean :)
>
>
>
http://codereview.chromium.org/6469072/diff/2001/session_manager_service.cc
> File session_manager_service.cc (right):
>
>
http://codereview.chromium.org/6469072/diff/2001/session_manager_service.cc#n...
> session_manager_service.cc:558:
> file_util::GetHomeDir().AppendASCII(kTemporaryKeyFilename).value());
> I was going to suggest a random location, but since the private key
> should be in nss, it seems fine to put the public key in the home dir.
> Is this a safe assumption?
>

That the private key is in nss?  Yes, that's a safe assumption.

And the session manager validates that the public key it got has a
counterpart in the user's nssdb.


>
> http://codereview.chromium.org/6469072/

Powered by Google App Engine
This is Rietveld 408576698