Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 6469067: WebUI: Move chrome/browser/dom_ui/options/ to chrome/browser/webui/options. (Closed)

Created:
9 years, 10 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

WebUI: Move chrome/browser/dom_ui/options/ to chrome/browser/webui/options. To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/options. I'll updated the references and delete the stub files later. BUG=59945, 59946 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75496

Patch Set 1 : #

Patch Set 2 : fix mac and windows #

Patch Set 3 : missing mac files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1782 lines, -1483 lines) Patch
M chrome/browser/dom_ui/options/about_page_handler.h View 1 chunk +4 lines, -57 lines 0 comments Download
M chrome/browser/dom_ui/options/add_startup_page_handler.h View 1 chunk +2 lines, -33 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.h View 1 chunk +2 lines, -173 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_utils.h View 1 chunk +4 lines, -17 lines 0 comments Download
M chrome/browser/dom_ui/options/autofill_options_handler.h View 1 chunk +3 lines, -69 lines 0 comments Download
M chrome/browser/dom_ui/options/browser_options_handler.h View 1 chunk +2 lines, -102 lines 0 comments Download
M chrome/browser/dom_ui/options/certificate_manager_handler.h View 1 chunk +2 lines, -151 lines 0 comments Download
M chrome/browser/dom_ui/options/clear_browser_data_handler.h View 2 chunks +3 lines, -45 lines 0 comments Download
M chrome/browser/dom_ui/options/content_settings_handler.h View 1 chunk +2 lines, -102 lines 0 comments Download
M chrome/browser/dom_ui/options/cookies_view_handler.h View 1 chunk +2 lines, -56 lines 0 comments Download
M chrome/browser/dom_ui/options/core_options_handler.h View 1 chunk +2 lines, -98 lines 0 comments Download
M chrome/browser/dom_ui/options/dom_options_util.h View 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/dom_ui/options/font_settings_handler.h View 1 chunk +2 lines, -34 lines 0 comments Download
M chrome/browser/dom_ui/options/font_settings_utils.h View 2 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/dom_ui/options/import_data_handler.h View 1 chunk +4 lines, -40 lines 0 comments Download
M chrome/browser/dom_ui/options/language_options_handler.h View 1 chunk +2 lines, -33 lines 0 comments Download
M chrome/browser/dom_ui/options/language_options_handler_common.h View 1 chunk +2 lines, -56 lines 0 comments Download
M chrome/browser/dom_ui/options/options_managed_banner_handler.h View 1 chunk +2 lines, -29 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.h View 1 chunk +2 lines, -109 lines 0 comments Download
M chrome/browser/dom_ui/options/password_manager_handler.h View 1 chunk +3 lines, -104 lines 0 comments Download
M chrome/browser/dom_ui/options/personal_options_handler.h View 1 chunk +2 lines, -56 lines 0 comments Download
M chrome/browser/dom_ui/options/search_engine_manager_handler.h View 1 chunk +3 lines, -64 lines 0 comments Download
M chrome/browser/dom_ui/options/stop_syncing_handler.h View 1 chunk +4 lines, -20 lines 0 comments Download
A + chrome/browser/webui/options/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/about_page_handler.h View 1 chunk +65 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/about_page_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/add_startup_page_handler.h View 1 chunk +43 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/add_startup_page_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/advanced_options_handler.h View 1 chunk +183 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/advanced_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/advanced_options_utils.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/advanced_options_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/webui/options/advanced_options_utils_mac.mm View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/webui/options/advanced_options_utils_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/webui/options/autofill_options_handler.h View 1 chunk +78 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/autofill_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/browser_options_handler.h View 1 chunk +112 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/browser_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/certificate_manager_handler.h View 1 chunk +161 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/certificate_manager_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/clear_browser_data_handler.h View 1 chunk +54 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/clear_browser_data_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/content_settings_handler.h View 1 chunk +112 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/content_settings_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/cookies_view_handler.h View 1 chunk +66 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/cookies_view_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/core_options_handler.h View 1 chunk +108 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/core_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/dom_options_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/dom_options_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/font_settings_handler.h View 1 chunk +44 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/font_settings_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/font_settings_utils.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/font_settings_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/webui/options/font_settings_utils_mac.mm View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/webui/options/font_settings_utils_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/import_data_handler.h View 1 chunk +48 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/import_data_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/language_options_handler.h View 1 chunk +43 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/language_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/language_options_handler_common.h View 1 chunk +66 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/language_options_handler_common.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/webui/options/language_options_handler_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/options_managed_banner_handler.h View 1 chunk +39 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/options_managed_banner_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/options_ui.h View 1 chunk +119 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/options_ui.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/webui/options/options_ui_uitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/password_manager_handler.h View 1 chunk +113 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/password_manager_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/personal_options_handler.h View 1 chunk +66 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/personal_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/search_engine_manager_handler.h View 1 chunk +73 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/search_engine_manager_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/webui/options/stop_syncing_handler.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + chrome/browser/webui/options/stop_syncing_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +52 lines, -29 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Please, take a look.
9 years, 10 months ago (2011-02-19 01:11:33 UTC) #1
Lei Zhang
LGTM
9 years, 10 months ago (2011-02-19 02:18:14 UTC) #2
tfarina
Weird. I'm unsure why this is failing on mac and windows. /b/build/slave/mac/build/src/chrome/browser/webui/options/certificate_manager_handler.cc:449: error: 'const class ...
9 years, 10 months ago (2011-02-19 02:34:04 UTC) #3
tfarina
9 years, 10 months ago (2011-02-19 02:38:03 UTC) #4
On 2011/02/19 02:34:04, tfarina wrote:
> Weird. I'm unsure why this is failing on mac and windows.
> 
>
/b/build/slave/mac/build/src/chrome/browser/webui/options/certificate_manager_handler.cc:449:
> error: 'const class net::CertDatabase' has no member named 'GetCertTrust'

I see now. They need to be excluded from mac and windows build. Uploading the
fix.

Powered by Google App Engine
This is Rietveld 408576698