Issue 6469059: VbNvStorage cleanup and comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6469059: VbNvStorage cleanup and comments (Closed)

Created:
9 years, 10 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

VbNvStorage cleanup and comments BUG=12282 TEST=make && make runtests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9e162cd

Patch Set 1 #

Patch Set 2 : Add legacy recovery reason #

Total comments: 4

Patch Set 3 : Fixes from code review #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -60 lines)			Patch
M	firmware/include/load_firmware_fw.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	firmware/include/load_kernel_fw.h	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	firmware/include/vboot_nvstorage.h	View	1	2 chunks	+81 lines, -17 lines	0 comments	Download
M	firmware/lib/vboot_nvstorage.c	View	1 2	2 chunks	+14 lines, -3 lines	0 comments	Download
M	firmware/linktest/main.c	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	tests/vboot_nvstorage_test.c	View		2 chunks	+2 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

9 years, 10 months ago (2011-02-18 23:51:50 UTC) #2

LGTM after you fix a couple of comments and a missing tilde.  Other remarks
require no action.

http://codereview.chromium.org/6469059/diff/1007/firmware/include/vboot_nvsto...
File firmware/include/vboot_nvstorage.h (right):

http://codereview.chromium.org/6469059/diff/1007/firmware/include/vboot_nvsto...
firmware/include/vboot_nvstorage.h:93: /* Initialize the NV storage library. 
This must be called before any
Third person in function comments.  (Also later comments.)

http://codereview.chromium.org/6469059/diff/1007/firmware/lib/vboot_nvstorage.c
File firmware/lib/vboot_nvstorage.c (right):

http://codereview.chromium.org/6469059/diff/1007/firmware/lib/vboot_nvstorage...
firmware/lib/vboot_nvstorage.c:122: 
Idle suggestion: since the header file mentions that it's illegal to call
get/set outside of setup/teardown, would it be worthwhile enforcing it?  It may
be too trivial---you can judge better if it would serve any purpose.

http://codereview.chromium.org/6469059/diff/1007/firmware/lib/vboot_nvstorage...
firmware/lib/vboot_nvstorage.c:156: raw[BOOT_OFFSET] &= BOOT_DEBUG_RESET_MODE;
Missing negation?

http://codereview.chromium.org/6469059/diff/1007/firmware/lib/vboot_nvstorage...
firmware/lib/vboot_nvstorage.c:161: raw[BOOT_OFFSET] |= (uint8_t)(value &
BOOT_TRY_B_COUNT);
Is it worth protecting from illegal values of VALUE?
Should you apply a shift to VALUE here instead of the caller?
(If any.)

Expand Messages | Collapse Messages