Issue 6469053: x64: implement apply with arguments in lithium backend.

Issue 6469053: x64: implement apply with arguments in lithium backend. (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

x64: implement apply with arguments in lithium backend. Includes the plumbing to make sure that all calls generated by the macroassembler for lithium will generate record a safepoint. Committed: http://code.google.com/p/v8/source/detail?r=6859

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -24 lines)			Patch
M	src/x64/assembler-x64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+95 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		6 chunks	+28 lines, -7 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		7 chunks	+36 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-codegen-x64.cc#newcode2034 src/x64/lithium-codegen-x64.cc:2034: Register scratch = ToRegister(instr->TempAt(0)); Can't we use our ...

9 years, 10 months ago (2011-02-18 16:49:11 UTC) #2

Mads Ager (chromium)

9 years, 10 months ago (2011-02-21 07:38:33 UTC) #3

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2034: Register scratch =
ToRegister(instr->TempAt(0));
On 2011/02/18 16:49:11, Rico wrote:
> Can't we use our normal kScratchRegister here?

Done.

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (right):

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-x64.h#newcode471
src/x64/lithium-x64.h:471: LOperand* temp) {
On 2011/02/18 16:49:11, Rico wrote:
> See comment in codegen, can't we just use kScratchRegister?

Done.

Expand Messages | Collapse Messages