Issue 6469052: x64: Implement regexp literals and string CharCodeAt in lithium backend.

Issue 6469052: x64: Implement regexp literals and string CharCodeAt in lithium backend. (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

x64: Implement regexp literals and string CharCodeAt in lithium backend. Committed: http://code.google.com/p/v8/source/detail?r=6853

Patch Set 2 : Addressing comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -19 lines)			Patch
M	src/ia32/assembler-ia32.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/x64/assembler-x64.h	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		1 chunk	+10 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+189 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM. http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#newcode2352 src/x64/lithium-codegen-x64.cc:2352: // We need special handling for non-flat strings. ...

9 years, 10 months ago (2011-02-18 13:22:25 UTC) #2

Mads Ager (chromium)

9 years, 10 months ago (2011-02-18 13:58:47 UTC) #3

Thanks!

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2352: // We need special handling for non-flat
strings.
On 2011/02/18 13:22:25, Lasse Reichstein wrote:
> ... special handling for non-sequential strings. (External strings are also
> flat).

Done.

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2378: // Check for 1-byte or 2-byte string.
On 2011/02/18 13:22:25, Lasse Reichstein wrote:
> You call it 1-byte string here and ASCII string below.
> Perhaps use either ASCII and UC16, or ASCII and TwoByte.

Done.

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2390: SeqTwoByteString::kHeaderSize + 2 *
const_index));
On 2011/02/18 13:22:25, Lasse Reichstein wrote:
> Use kUC16Size instead of 2.

Done.

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2445: __ Integer32ToSmi(rax, rax);
On 2011/02/18 13:22:25, Lasse Reichstein wrote:
> Should be SmiToInteger32.

Whoops! Done.

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2448: __ PopSafepointRegisters();
On 2011/02/18 13:22:25, Lasse Reichstein wrote:
> We could make an alternative version: PopSafepointRegistersExcept(Register
> to_omit)
> and then just move the result from rax to result before popping the rest.
> Can't say if it'll be worth it, though.

Don't think it will. Will leave that for a separate experiment on all platforms.

http://codereview.chromium.org/6469052/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2825: // Result will be in eax.
On 2011/02/18 13:22:25, Lasse Reichstein wrote:
> eax->rax

Done.

Expand Messages | Collapse Messages