Issue 6469050: Clear exceptions set during attempts to lazily optimize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6469050: Clear exceptions set during attempts to lazily optimize. (Closed)

Created:
9 years, 10 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32

Visibility:
Public.

Description

Clear exceptions set during attempts to lazily optimize. Resubmit of patch for issue 1145 with a few additions: - Now also clears exceptions when calling Runtime_LazyRecompile. - Sets function where parsing fails to not be optimizable. BUG=v8:1145 TEST=test/mjsunit/regress/regress-1145.js Committed: http://code.google.com/p/v8/source/detail?r=6945

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -8 lines)			Patch
M	src/handles.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/handles.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	4 chunks	+7 lines, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-1145.js	View	1 chunk	+54 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

9 years, 10 months ago (2011-02-25 11:15:50 UTC) #3

LGTM.

http://codereview.chromium.org/6469050/diff/1/test/mjsunit/regress/regress-11...
File test/mjsunit/regress/regress-1145.js (right):

http://codereview.chromium.org/6469050/diff/1/test/mjsunit/regress/regress-11...
test/mjsunit/regress/regress-1145.js:31: // Should not throw a syntax error
exception (change this if we make lazily.
remove extra period at line-end.

Expand Messages | Collapse Messages